Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-19 Thread via GitHub
Apache9 merged PR #5690: URL: https://github.com/apache/hbase/pull/5690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-19 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951896172 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 44s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951871696 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 13s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951657370 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951621133 Let me fix the failed UT, seems we could also have other types of exceptions when server close the connection. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951429766 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951427028 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 12s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache-HBase commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951372283 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
bbeaudreault commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951371107 I'm not an expert on sasl. It makes some sense that if we fallback to simple, we don't need a saslRpcClient. But can you explain a little more what the issue was and why this change

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951359539 @bbeaudreault We need to fix this before landing HBASE-28321. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 commented on PR #5690: URL: https://github.com/apache/hbase/pull/5690#issuecomment-1951359301 The fix itself is very simple, just set `saslRpcClient` to `null` when we want to fallback to simple auth at client side. The most important changes are the newly added tests in

[PR] HBASE-28377 Fallback to simple is broken for blocking rpc client [hbase]

2024-02-18 Thread via GitHub
Apache9 opened a new pull request, #5690: URL: https://github.com/apache/hbase/pull/5690 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,