Apache9 merged PR #5799:
URL: https://github.com/apache/hbase/pull/5799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2081173806
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2081173478
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2081172462
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2081073324
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 24s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2081002490
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2080994527
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2080988852
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 40s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2080552350
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074998054
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074971986
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074885268
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 57s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074490831
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 26s |
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074425769
Test failure seems to be a weired issue. Idealy the split in the
testmergeRegions should have failed. But we are throwing a different exception
in our case. I am changing the test to
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074401724
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074401629
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074401648
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2074401597
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 0s |
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2072294888
@Apache9 test is failing with error message
"org.apache.hadoop.hbase.quotas.QuotaExceededException: Region split not
possible for :4c01d4827cdd730e51f83b314ebebbbf as quota limits are
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2067741151
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2067730189
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2067720269
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2067664456
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache9 commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2067655889
Test failure seems related? There is a region merge related test failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2067645298
@virajjasani @Apache9 ping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2055775609
Writing test here is little tricky. Not sure if it is possible to mimic the
same failure. I tried all the available options in proceduretestingutility and
don't see the right fit for our
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2044165443
> The latest fix LGTM.
>
> Could we add a UT for this case?
Trying to write a test. Little tricky as i haven't looked at
ProcedureTestingUtility as of now. Will see what i
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2043228894
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2043165670
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2043161214
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2042635972
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041634955
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 35s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041628940
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 31s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041625975
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
virajjasani commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041555045
> I think i made a mistake. A small but important one which breaks/"doesn't
follow" the design of rollback in procedure framework. We didnot change
regionNode state in
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041553082
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041547399
I think i made a mistake. A small but important one which breaks the design
of rollback in procedure framework.
We didnot change regionNode state in `MERGE_TABLE_REGIONS_CLOSE_REGIONS`
virajjasani commented on code in PR #5799:
URL: https://github.com/apache/hbase/pull/5799#discussion_r1555020386
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java:
##
@@ -639,8 +639,22 @@ private void
virajjasani commented on code in PR #5799:
URL: https://github.com/apache/hbase/pull/5799#discussion_r1555019484
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java:
##
@@ -639,8 +639,22 @@ private void
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041544428
If it matters i test with very rudimentary way
Changed MergeTableRegionProcedure method
```
private TransitRegionStateProcedure[]
createUnassignProcedures(MasterProcedureEnv env)
mnpoonia commented on code in PR #5799:
URL: https://github.com/apache/hbase/pull/5799#discussion_r1555018299
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java:
##
@@ -639,8 +639,27 @@ private void cleanupMergedRegion(final
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041512797
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041511557
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 42s |
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041509329
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 54s |
Apache9 commented on code in PR #5799:
URL: https://github.com/apache/hbase/pull/5799#discussion_r1554949639
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java:
##
@@ -639,8 +639,27 @@ private void cleanupMergedRegion(final
Apache-HBase commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041439330
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 15s |
mnpoonia commented on PR #5799:
URL: https://github.com/apache/hbase/pull/5799#issuecomment-2041427749
@virajjasani FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mnpoonia opened a new pull request, #5799:
URL: https://github.com/apache/hbase/pull/5799
…d and is still in state merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
48 matches
Mail list logo
