bbeaudreault commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021115402
Pre-commit looks good. There is 1 checkstyle issue. Branch permissions don't
allow me to commit to this PR, so I'm going to cherry-pick it rather than merge.
Closing this and
bbeaudreault closed pull request #5776: HBASE-28412 Select correct target table
for incremental backup
URL: https://github.com/apache/hbase/pull/5776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021094695
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021093977
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021082313
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021066328
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2021002223
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020995259
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020972463
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 22s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020970457
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 23s |
rubenvw-ngdata commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539650301
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/BackupTestUtil.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
rubenvw-ngdata commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539649431
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -18,6 +18,7 @@
package
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539624430
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -18,6 +18,7 @@
package org.apache.hadoop.hbase.backup;
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539621891
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/BackupTestUtil.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
rubenvw-ngdata commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539574336
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
rubenvw-ngdata commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539531767
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539518711
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
rubenvw-ngdata commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539479695
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539470479
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539449576
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
rubenvw-ngdata commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539447876
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020368143
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 3m 41s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020355217
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020352997
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5776:
URL: https://github.com/apache/hbase/pull/5776#issuecomment-2020327457
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539147304
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
bbeaudreault commented on code in PR #5776:
URL: https://github.com/apache/hbase/pull/5776#discussion_r1539139640
##
hbase-backup/src/test/java/org/apache/hadoop/hbase/backup/TestBackupRestoreWithModifications.java:
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the Apache Software
28 matches
Mail list logo
