Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111814481
> > > Both approaches have their own drawbacks. I still wonder what we can
do here for ConnectionRegistry timeouts, given that Zookeeper response might
never come back for timer to be
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111800160
> > Both approaches have their own drawbacks. I still wonder what we can do
here for ConnectionRegistry timeouts, given that Zookeeper response might never
come back for timer to be
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111748836
> Both approaches have their own drawbacks. I still wonder what we can do
here for ConnectionRegistry timeouts, given that Zookeeper response might never
come back for timer to be
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111746391
Both approaches have their own drawbacks.
I still wonder what we can do here for ConnectionRegistry timeouts, given
that Zookeeper response might never come back for timer to be
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2111493641
> > Here you just submit the async zk operation in the timer task, and then
in the callback, you check reschedule the timer task and then you have a chance
to check timeout, but what if
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2110914019
> Here you just submit the async zk operation in the timer task, and then in
the callback, you check reschedule the timer task and then you have a chance to
check timeout, but what if
Apache9 commented on code in PR #5837:
URL: https://github.com/apache/hbase/pull/5837#discussion_r1599917696
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaRegionLocator.java:
##
@@ -25,6 +25,7 @@
import java.util.concurrent.CompletableFuture;
import
virajjasani commented on code in PR #5837:
URL: https://github.com/apache/hbase/pull/5837#discussion_r1599411467
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ZKConnectionRegistry.java:
##
@@ -70,6 +73,11 @@ class ZKConnectionRegistry implements
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108938449
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108931751
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 1s |
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108889817
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 10s |
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2108528810
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2096066904
Have you guys find the way to use timer to implement the timeout?
You can see the code in AsyncRpcRetryingCaller.
And for ZKConnectionRegistry, you can pass the TIMER in
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2083463566
Here, `TimerTask` is used within `addListener()`, hence we can make somewhat
similar change in `ZKConnectionRegistry`.
--
This is an automated message from the Apache Git Service.
To
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2083461473
The other example is for `execProcedure`:
```
@Override
public CompletableFuture execProcedure(String signature, String
instance,
Map props) {
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2083455858
@Divneet18 here is the sample for TimerTask and how we can introduce timeout:
```
TimerTask pollingTask = new TimerTask() {
int tries = 0;
long
Divneet18 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2075508802
@Apache9 where can I find the AsynRpcConnectionImpl code? We tried finding
it but are having no luck in the master code base. Thank you
--
This is an automated message from the Apache
Apache9 commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2071575451
You can see how we implement timeout in AsyncRpcConnectionImpl...
There is a timer, when we reach timeout, the timer task will call
completeExceptionally method of the
virajjasani commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2071330417
@Apache9 how do we ensure the timeout is considered by AsynFuture?
ConnectionRegistry APIs return AsyncFuture so if we implement timeout on
AsyncFuture as part of connection registry
Apache9 commented on code in PR #5837:
URL: https://github.com/apache/hbase/pull/5837#discussion_r1572305997
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java:
##
@@ -326,15 +328,17 @@ CompletableFuture
getMasterStub() {
}
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065661292
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 27s |
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065641841
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065637516
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5837:
URL: https://github.com/apache/hbase/pull/5837#issuecomment-2065441599
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 41s |
24 matches
Mail list logo
