bbeaudreault commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041143715
I investigated and it does seem like a true duplicate. I don't think this
was related, but it's ok. More importantly, the spotless formatting issues have
been fixed. Going to merge
bbeaudreault merged PR #5795:
URL: https://github.com/apache/hbase/pull/5795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
bbeaudreault commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041051470
What I was referring to about spotless was this error in the first build:
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041044628
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041044689
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041044074
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041040126
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
thomassngdata commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2041033620
Issue with `mvn spotless:apply -pl hbase-backup` was a duplicate
`hamcrest-library` dependency in hbase-replication/pom.xml, nothing to do with
my PR but fixed it.
--
This is an
bbeaudreault commented on code in PR #5795:
URL: https://github.com/apache/hbase/pull/5795#discussion_r1553565029
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileInputFormat.java:
##
@@ -155,16 +154,23 @@ protected List listStatus(JobContext job)
throws
bbeaudreault commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039713845
Also please run `mvn spotless:apply -pl hbase-backups`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039376139
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 46s |
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039371921
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 29s |
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039369922
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 32s |
Apache-HBase commented on PR #5795:
URL: https://github.com/apache/hbase/pull/5795#issuecomment-2039328476
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 30s |
14 matches
Mail list logo
