ndimiduk commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2112749361
Merged to master. I'll start backporting and holler if I have any issues.
Thanks for the contribution @DieterDP-ng and for the review @rmdmattingly !
--
This is an automated message
ndimiduk merged PR #5871:
URL: https://github.com/apache/hbase/pull/5871
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
joshelser commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2108176794
sorry, I don't recall exactly what was being put into the incremental
backups anymore. I remember holding on to all of the WAL files quickly got out
of control and we talked about
DieterDP-ng commented on code in PR #5871:
URL: https://github.com/apache/hbase/pull/5871#discussion_r1598573660
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java:
##
@@ -102,24 +95,6 @@ public static Path getTableBackupPath(TableName
DieterDP-ng commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2107727003
> Looks good to me. It would be good to solicit comments from whomever made
the change that deprecated the old manifest logic in the first place.
@DieterDP-ng do you know whom that
ndimiduk commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2104294247
Looks like both modified test methods were executed and passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ndimiduk commented on code in PR #5871:
URL: https://github.com/apache/hbase/pull/5871#discussion_r1596521351
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java:
##
@@ -102,24 +95,6 @@ public static Path getTableBackupPath(TableName tableName,
Apache-HBase commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2093661849
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
Apache-HBase commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2093651831
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 28s |
Apache-HBase commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2093650993
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 36s |
Apache-HBase commented on PR #5871:
URL: https://github.com/apache/hbase/pull/5871#issuecomment-2093642616
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 25s |
DieterDP-ng opened a new pull request, #5871:
URL: https://github.com/apache/hbase/pull/5871
In older versions of HBase's backup mechanism, a manifest was written per
table being backed up. This was since refactored to one manifest per backup,
but the manifest code was not updated. A
12 matches
Mail list logo
