[
https://issues.apache.org/jira/browse/HBASE-15887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299121#comment-15299121
]
Clay B. edited comment on HBASE-15887 at 5/24/16 11:08 PM:
-----------------------------------------------------------
This patch provides an {{hbaselogs}} test which provides the following vote
table additions (it will never -1 only 0 or +1):
{code}
| +1 | hbaselogs | 0m 0s | Patch changed +2/-0 debug log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 error log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 fatal log entries
| +1 | hbaselogs | 0m 0s | Patch changed +2/-2 info log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 trace log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 warn log entries
{code}
And in the general output the following is provided:
{code}
============================================================================
============================================================================
Checking for changed log entries
============================================================================
============================================================================
Patch changed debug info log entries
{code}
This was tested via*:
{code}
${YETUS_HOME}/precommit/test-patch.sh --plugins=all,hbaselogs,-hadoopcheck
--personality=dev-support/hbase-personality.sh HBASE-15391
{code}
* I needed to change line 353:
{code}
verify_needed_test hbaselogs
if [[ $? == 0 ]]; then
{code}
To:
{{if [[ $? == 1 ]]; then}}
In order for the {{hbaselogs}} check to run. I suspect I am missing how to tell
Yetus to run things properly but this inequality seemingly set to not run a
test if it is verified needed is how the other tests are implemented.
Lastly, I do not print out the log lines as I am doing a rather crude {{grep}}
for {{LOG.<level>}} entries right now which look pretty gnarly. However, I
would like to see this go to Yetus and use something like [Eclipse's
AST|http://www.eclipse.org/articles/article.php?file=Article-JavaCodeManipulation_AST/index.html]
support to properly find log entry parameters and calls.
was (Author: clayb):
This patch provides an {{hbaselogs}} test which provides the following vote
table additions (it will never -1 only 0 or +1):
{code}
| +1 | hbaselogs | 0m 0s | Patch changed +2/-0 debug log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 error log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 fatal log entries
| +1 | hbaselogs | 0m 0s | Patch changed +2/-2 info log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 trace log entries
| 0 | hbaselogs | 0m 0s | Patch changed 0 warn log entries
{code}
And in the general output the following is provided:
{code}
============================================================================
============================================================================
Checking for changed log entries
============================================================================
============================================================================
Patch changed debug info log entries
{code}
This was tested via*:
{{${YETUS_HOME}/precommit/test-patch.sh --plugins=all,hbaselogs,-hadoopcheck
--personality=dev-support/hbase-personality.sh HBASE-15391}}
* I needed to change line 353:
{code}
verify_needed_test hbaselogs
if [[ $? == 0 ]]; then
{code}
To:
{{ if [[ $? == 1 ]]; then}}
In order for the {{hbaselogs}} check to run. I suspect I am missing how to tell
Yetus to run things properly but this inequality seemingly set to not run a
test if it is verified needed is how the other tests are implemented.
Lastly, I do not print out the log lines as I am doing a rather crude {{grep}}
for {{LOG.<level>}} entries right now which look pretty gnarly. However, I
would like to see this go to Yetus and use something like [Eclipse's
AST|http://www.eclipse.org/articles/article.php?file=Article-JavaCodeManipulation_AST/index.html]
support to properly find log entry parameters and calls.
> Report Log Additions and Removals in Builds
> -------------------------------------------
>
> Key: HBASE-15887
> URL: https://issues.apache.org/jira/browse/HBASE-15887
> Project: HBase
> Issue Type: New Feature
> Components: build
> Reporter: Clay B.
> Priority: Trivial
> Attachments: HBASE-15887-v1.txt
>
>
> It would be very nice for the Apache Yetus verifications of HBase patches to
> report log item addition and deletions.
> This is not my idea but Matthew Byng-Maddick asked if we could modify the
> personality for reporting log additions and removals yesterday at an [HBase
> meetup at Splice
> machine|http://www.meetup.com/hbaseusergroup/events/230547750/] as Allen
> Wittenauer presented Apache Yetus for building HBase.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
