[ 
https://issues.apache.org/jira/browse/HBASE-21635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727984#comment-16727984
 ] 

Nihal Jain edited comment on HBASE-21635 at 12/23/18 3:02 PM:
--------------------------------------------------------------

{{TestQuotasShell}} seems to have failed due to 
[HBASE-21631|https://issues.apache.org/jira/projects/HBASE/issues/HBASE-21631]. 
The assertion @ 
[quotas_test.rb#L103|https://github.com/apache/hbase/blob/7c0a3cc265f1351363dc88f2f70855b3273dd8c6/hbase-shell/src/test/ruby/hbase/quotas_test.rb#L103]
 needs to be fixed after this improvement. [~jatsakthi] You might want to have 
a look at this.


was (Author: nihaljain.cs):
{{TestQuotasShell}} seems to have failed due to 
[HBASE-21631|https://issues.apache.org/jira/projects/HBASE/issues/HBASE-21631] 
The assertion needs to be fixed after this improvement. [~jatsakthi] You might 
want to have a look at this.

> Use maven enforcer to ban imports from illegal packages
> -------------------------------------------------------
>
>                 Key: HBASE-21635
>                 URL: https://issues.apache.org/jira/browse/HBASE-21635
>             Project: HBase
>          Issue Type: Improvement
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>         Attachments: HBASE-21635.patch
>
>
> Now we use checkstyle to report the illegal imports, but it will be easy to 
> be ignored by developpers.
> https://github.com/skuzzle/restrict-imports-enforcer-rule
> This is an extension for the maven enforcer plugin, which is used to ban 
> imports, and the advantage is that it will cause a compile error, which is 
> not likely to be ignored. The extension is not perfect, but I think it is 
> worth a try.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to