[ https://issues.apache.org/jira/browse/HBASE-9167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13741478#comment-13741478 ]
Jimmy Xiang edited comment on HBASE-9167 at 8/15/13 9:08 PM: ------------------------------------------------------------- Attached patvh v2. HBASE-9156 doesn't apply to 0.94 so it is not backported. We also fixed the call duration calculation. was (Author: jxiang): Attached patvh v2. HBASE-9516 doesn't apply to 0.94 so it is not backported. > ServerCallable retries just once if timeout is not integer.max > -------------------------------------------------------------- > > Key: HBASE-9167 > URL: https://issues.apache.org/jira/browse/HBASE-9167 > Project: HBase > Issue Type: Bug > Components: Client > Affects Versions: 0.94.10 > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Attachments: 0.94-9167.patch, 0.94-9167_v2.patch > > > If callTimeout is not integer.max and throwable is not > SocketTimeoutException, we set the callTimeout to a negative value since > endTime is not set yet. Therefore, the next call will always throw > SocketTimeoutException. > {noformat} > if (this.callTimeout != HConstants.DEFAULT_HBASE_CLIENT_OPERATION_TIMEOUT) > if (throwable instanceof SocketTimeoutException > || (this.endTime - this.startTime > this.callTimeout)) { > throw (SocketTimeoutException) (SocketTimeoutException) new > SocketTimeoutException( > "Call to access row '" + Bytes.toString(row) + "' on table '" > + Bytes.toString(tableName) > + "' failed on socket timeout exception: " + throwable) > .initCause(throwable); > } else { > ===> this.callTimeout = ((int) (this.endTime - this.startTime)); > } > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira