[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899401#comment-13899401 ] Ted Yu commented on HBASE-10452: [~apurtell]: What do you think of patch v3 ? Potential

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-10 Thread Ding Yuan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896424#comment-13896424 ] Ding Yuan commented on HBASE-10452: --- Thanks for the comments! Attached a new patch to

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896489#comment-13896489 ] Hadoop QA commented on HBASE-10452: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-09 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896228#comment-13896228 ] Andrew Purtell commented on HBASE-10452: Adding error logging is fine. Throwing

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-09 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896236#comment-13896236 ] stack commented on HBASE-10452: --- Thanks for looking into this [~d.yuan] All looks good to

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-04 Thread Ding Yuan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890844#comment-13890844 ] Ding Yuan commented on HBASE-10452: --- Thanks Ram! Attaching a patch against trunk. I did

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890916#comment-13890916 ] Ted Yu commented on HBASE-10452: nit: {code} + throw new RuntimeException(TimeRange

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13890939#comment-13890939 ] Hadoop QA commented on HBASE-10452: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-04 Thread Ding Yuan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891109#comment-13891109 ] Ding Yuan commented on HBASE-10452: --- Thanks Ted! Fixed both the line wrapping and the

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13891326#comment-13891326 ] Hadoop QA commented on HBASE-10452: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10452) Potential bugs in exception handlers

2014-02-02 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13889210#comment-13889210 ] ramkrishna.s.vasudevan commented on HBASE-10452: Thanks for checking