[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-21 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908183#comment-13908183 ] Feng Honghua commented on HBASE-10516: -- [~nkeywal], thanks! :-) Refactor code

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908306#comment-13908306 ] Hudson commented on HBASE-10516: SUCCESS: Integrated in HBase-TRUNK #4940 (See

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13909144#comment-13909144 ] Hudson commented on HBASE-10516: SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #96

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-20 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13907837#comment-13907837 ] Feng Honghua commented on HBASE-10516: -- [~nkeywal], can this be committed as well?

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-19 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905077#comment-13905077 ] Feng Honghua commented on HBASE-10516: -- bq.Nice writeup @nkeywal (and nice

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-19 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905088#comment-13905088 ] Nicolas Liochon commented on HBASE-10516: - I'm +1 for v3. I will commit shortly

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-19 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905335#comment-13905335 ] Feng Honghua commented on HBASE-10516: -- bq.Sorry again the the review in 2 passes No

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13905474#comment-13905474 ] Hadoop QA commented on HBASE-10516: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-19 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13906596#comment-13906596 ] Feng Honghua commented on HBASE-10516: -- I rerun the unit tests locally for this

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903913#comment-13903913 ] Nicolas Liochon commented on HBASE-10516: - I'm ok with the new patch. Thanks! I

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903965#comment-13903965 ] Feng Honghua commented on HBASE-10516: -- bq. AssignmentManager = It's not really

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903973#comment-13903973 ] Feng Honghua commented on HBASE-10516: -- bq.Seems we should discuss and agree on a

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903994#comment-13903994 ] Nicolas Liochon commented on HBASE-10516: - bq. Should we treat it case-by-case,

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread Feng Honghua (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903998#comment-13903998 ] Feng Honghua commented on HBASE-10516: -- Thanks [~nkeywal], let me re-examine the

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904012#comment-13904012 ] Nicolas Liochon commented on HBASE-10516: - ok :-) Refactor code where

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-18 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13904835#comment-13904835 ] stack commented on HBASE-10516: --- Nice writeup @nkeywal (and nice commentary [~fenghh] --

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-17 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903302#comment-13903302 ] Nicolas Liochon commented on HBASE-10516: - sleepBeforeRetry = sure createDir =

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13903804#comment-13903804 ] Hadoop QA commented on HBASE-10516: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-14 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901213#comment-13901213 ] Nicolas Liochon commented on HBASE-10516: - It seems ok to me, but give me some

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901342#comment-13901342 ] Hadoop QA commented on HBASE-10516: --- {color:red}-1 overall{color}. Here are the

[jira] [Commented] (HBASE-10516) Refactor code where Threads.sleep is called within a while/for loop

2014-02-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13901102#comment-13901102 ] stack commented on HBASE-10516: --- eww. Its ugly. But makes sense. +1 from me. [~nkeywal]