[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-10 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965392#comment-13965392 ] Nicolas Liochon commented on HBASE-10813: - Thanks for the fix, Michael. Thanks

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-10 Thread Ding Yuan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13965397#comment-13965397 ] Ding Yuan commented on HBASE-10813: --- Thanks all! Possible over-catch of exceptions

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-09 Thread Ding Yuan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964204#comment-13964204 ] Ding Yuan commented on HBASE-10813: --- Hi folks, any chance to commit this patch soon?

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-09 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964277#comment-13964277 ] Nicolas Liochon commented on HBASE-10813: - I need to have a look at the point you

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-09 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964316#comment-13964316 ] Nicolas Liochon commented on HBASE-10813: - Hum, it seems safer to abord here:

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-09 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964323#comment-13964323 ] Nicolas Liochon commented on HBASE-10813: - Oops, now that I've just committed it,

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-09 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964646#comment-13964646 ] Hudson commented on HBASE-10813: FAILURE: Integrated in HBase-TRUNK #5074 (See

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-04-09 Thread Mikhail Antonov (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13964813#comment-13964813 ] Mikhail Antonov commented on HBASE-10813: - That's assuming (according to

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-03-25 Thread Ding Yuan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13946396#comment-13946396 ] Ding Yuan commented on HBASE-10813: --- One comment for this code block: {noformat}

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-03-24 Thread haosdent (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13944831#comment-13944831 ] haosdent commented on HBASE-10813: -- {quote} Over-catching these exceptions may

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-03-24 Thread Nicolas Liochon (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945150#comment-13945150 ] Nicolas Liochon commented on HBASE-10813: - yep, lgtm. Will commit if there is no

[jira] [Commented] (HBASE-10813) Possible over-catch of exceptions

2014-03-24 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13945800#comment-13945800 ] stack commented on HBASE-10813: --- lgtm and lgtm for 0.96 but not going to hold up RC for it.