[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162736#comment-16162736
]
ramkrishna.s.vasudevan commented on HBASE-10944:
bq.We have to undeprecate also.
I
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162695#comment-16162695
]
Anoop Sam John commented on HBASE-10944:
This issue speak abt remove refs to kv.getBuffer() and
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162619#comment-16162619
]
ramkrishna.s.vasudevan commented on HBASE-10944:
Will attach a patch and do it. I think
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161867#comment-16161867
]
stack commented on HBASE-10944:
---
[~ram_krish] Ok then. Do you want to do the honors resolving? The removal
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160811#comment-16160811
]
ramkrishna.s.vasudevan commented on HBASE-10944:
bq.Am fine with expsosing it for Cells.
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160770#comment-16160770
]
Anoop Sam John commented on HBASE-10944:
I read RowIndexCodecV1 and it is doing this in
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160764#comment-16160764
]
stack commented on HBASE-10944:
---
bq. Am fine with expsosing it for Cells. Add a clear comment saying avoid
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160734#comment-16160734
]
Anoop Sam John commented on HBASE-10944:
bq.I just did a final search of kv.getBuffer - we have
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160672#comment-16160672
]
ramkrishna.s.vasudevan commented on HBASE-10944:
Am fine with expsosing it for Cells. Add
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159365#comment-16159365
]
stack commented on HBASE-10944:
---
[~ram_krish] See above comment sir.
> Remove all kv.getBuffer() and
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16140735#comment-16140735
]
stack commented on HBASE-10944:
---
We can resolve this now until someone proves otherwise? And then the
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133202#comment-16133202
]
ramkrishna.s.vasudevan commented on HBASE-10944:
Yes we could do that. I can give a patch
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16133146#comment-16133146
]
stack commented on HBASE-10944:
---
Can we deprecate and put in place an alternative method?
> Remove all
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131800#comment-16131800
]
ramkrishna.s.vasudevan commented on HBASE-10944:
bq.We should deprecate the MR usage for
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130853#comment-16130853
]
stack commented on HBASE-10944:
---
We should deprecate the MR usage for 2.0.0?
We should open an issue to
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130324#comment-16130324
]
Anoop Sam John commented on HBASE-10944:
Ya we no longer use KV directly in the code path. All
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129039#comment-16129039
]
stack commented on HBASE-10944:
---
How to move forward here? I like the [~ram_krish] suggestion. #getBuffer
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961239#comment-15961239
]
Anoop Sam John commented on HBASE-10944:
bq.We have Cells, but not quite, and in important places
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961229#comment-15961229
]
Lars Hofhansl commented on HBASE-10944:
---
How about we get rid of ensureKeyValue? Right now we're in
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960848#comment-15960848
]
Chia-Ping Tsai commented on HBASE-10944:
bq. May be we should not expose it public but for test
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956825#comment-15956825
]
Anoop Sam John commented on HBASE-10944:
kv.getRow() is no longer there.
kv.getBuffer () ->
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956801#comment-15956801
]
Chia-Ping Tsai commented on HBASE-10944:
These methods should be removed when moving 2.0 forward.
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499184#comment-14499184
]
Anoop Sam John commented on HBASE-10944:
Most of the calls have gone away now by
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14498667#comment-14498667
]
stack commented on HBASE-10944:
---
Where are we on this issue [~ram_krish] and @anoop sam
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119332#comment-14119332
]
Anoop Sam John commented on HBASE-10944:
[~ram_krish] How abt close this and
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14119371#comment-14119371
]
ramkrishna.s.vasudevan commented on HBASE-10944:
Ya I could raise sub
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117386#comment-14117386
]
Anoop Sam John commented on HBASE-10944:
Removing all in one short will be too
[
https://issues.apache.org/jira/browse/HBASE-10944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996070#comment-13996070
]
ramkrishna.s.vasudevan commented on HBASE-10944:
The thing here to be
28 matches
Mail list logo
