[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151655#comment-15151655
]
Sean Busbey commented on HBASE-14355:
-
no longer incompatible after fix in HBASE-15283
> Scan
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151151#comment-15151151
]
Sean Busbey commented on HBASE-14355:
-
I believe [~jmhsieh] is working on a fix in HBASE-15283
>
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150820#comment-15150820
]
churro morales commented on HBASE-14355:
[~busbey] I can revert that change and get patches for
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028396#comment-15028396
]
Hudson commented on HBASE-14355:
FAILURE: Integrated in HBase-Trunk_matrix #504 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028500#comment-15028500
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-1.2 #404 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028634#comment-15028634
]
Hudson commented on HBASE-14355:
FAILURE: Integrated in HBase-1.3 #400 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028318#comment-15028318
]
Hudson commented on HBASE-14355:
FAILURE: Integrated in HBase-1.2-IT #310 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028281#comment-15028281
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-1.3-IT #341 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023981#comment-15023981
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023747#comment-15023747
]
Anoop Sam John commented on HBASE-14355:
Change looks fine. Attach it as an addendum patch.
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023774#comment-15023774
]
stack commented on HBASE-14355:
---
What [~anoop.hbase] says [~churromorales] Addendums go in soon after
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023919#comment-15023919
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023042#comment-15023042
]
churro morales commented on HBASE-14355:
[~apurtell] Hi Andrew, we have a patch for 98 and are
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005296#comment-15005296
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-1.3 #365 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005322#comment-15005322
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-1.2 #368 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005431#comment-15005431
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-1.3-IT #311 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005210#comment-15005210
]
stack commented on HBASE-14355:
---
Pushed to branch-1 and branch-1.2. I had to run protoc for 1.2 weirdly.
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15005235#comment-15005235
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-1.2-IT #281 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002947#comment-15002947
]
churro morales commented on HBASE-14355:
Thanks [~stack], sure thing I will regenerate the PB for
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003014#comment-15003014
]
churro morales commented on HBASE-14355:
[~apurtell] we patched this for our 98 cluster. Would
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002913#comment-15002913
]
stack commented on HBASE-14355:
---
I pushed the patch to master branch.
branch-1 looks like it needs pb
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003284#comment-15003284
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003201#comment-15003201
]
Hudson commented on HBASE-14355:
SUCCESS: Integrated in HBase-Trunk_matrix #461 (See
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15001368#comment-15001368
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1433#comment-1433
]
Anoop Sam John commented on HBASE-14355:
Seems patch is not applying cleanly ( ClientProtos.java
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997262#comment-14997262
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997730#comment-14997730
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993510#comment-14993510
]
Anoop Sam John commented on HBASE-14355:
No problem.. Will commit it then. Thanks.
> Scan
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14993167#comment-14993167
]
churro morales commented on HBASE-14355:
[~anoop] sorry been sick for the past week, will get you
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14991103#comment-14991103
]
Anoop Sam John commented on HBASE-14355:
[~churromorales] Can u address latest comment from
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986400#comment-14986400
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986414#comment-14986414
]
stack commented on HBASE-14355:
---
v8 changes the contract still?
204 public Get setTimeRange(long
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14982096#comment-14982096
]
Anoop Sam John commented on HBASE-14355:
Looks good. As Stack said we can avoid the API changes.
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980921#comment-14980921
]
stack commented on HBASE-14355:
---
I skimmed the patch. It looks great. Address [~anoop.hbase] review then
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980755#comment-14980755
]
churro morales commented on HBASE-14355:
Hi Anoop, thanks for the comments...
I understand the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14980804#comment-14980804
]
Anoop Sam John commented on HBASE-14355:
The existing fields may be u can leave. For those new
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981089#comment-14981089
]
Anoop Sam John commented on HBASE-14355:
Override the setter for cfTimeRange in Scan and Get. In
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981006#comment-14981006
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981097#comment-14981097
]
churro morales commented on HBASE-14355:
I would only need to override the setters as the getters
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981100#comment-14981100
]
churro morales commented on HBASE-14355:
sorry misread your comment, I'll do that in this patch
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981422#comment-14981422
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981871#comment-14981871
]
stack commented on HBASE-14355:
---
[~churromorales] You are changing a public API here:
- public Get
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981725#comment-14981725
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981741#comment-14981741
]
churro morales commented on HBASE-14355:
Okay fellas looks like 7th time was a charm. Good to
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14976015#comment-14976015
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977596#comment-14977596
]
churro morales commented on HBASE-14355:
[~stack] The tests all pass, what do you think about the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977758#comment-14977758
]
Anoop Sam John commented on HBASE-14355:
Ya no need to worry abt line length issue in PB
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977755#comment-14977755
]
Anoop Sam John commented on HBASE-14355:
Some comments
- The Map for cf vs TimeRange is repeated
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975009#comment-14975009
]
stack commented on HBASE-14355:
---
Patch looks good. Needs fat release note. Seems harmless enough. Could
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975219#comment-14975219
]
stack commented on HBASE-14355:
---
Put up a branch-1 patch and'we'll backport it [~churromorales] [~apurtell]
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975201#comment-14975201
]
churro morales commented on HBASE-14355:
[~stack] I agree, that makes things a lot cleaner. My
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14975688#comment-14975688
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971842#comment-14971842
]
Ted Yu commented on HBASE-14355:
If this only goes to master branch, I am fine with the latest patch.
>
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971877#comment-14971877
]
churro morales commented on HBASE-14355:
[~stack] any thoughts about getting this into master? :)
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14969611#comment-14969611
]
Dave Latham commented on HBASE-14355:
-
Regarding the API, it is adding non-abstract methods. For 2.0
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14965508#comment-14965508
]
churro morales commented on HBASE-14355:
We have to add to the API to have this feature. Is
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14966127#comment-14966127
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14962811#comment-14962811
]
Ted Yu commented on HBASE-14355:
Get / Scan are marked Stable.
Is adding new method such as
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14958199#comment-14958199
]
churro morales commented on HBASE-14355:
The line lengths are from auto generated protobuf code.
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957999#comment-14957999
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956160#comment-14956160
]
Hadoop QA commented on HBASE-14355:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956198#comment-14956198
]
Ted Yu commented on HBASE-14355:
{code}
83private Map cftr = new
[
https://issues.apache.org/jira/browse/HBASE-14355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956219#comment-14956219
]
churro morales commented on HBASE-14355:
Sure I'll fix the individual imports. I was thinking
63 matches
Mail list logo