[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087681#comment-15087681
]
Hudson commented on HBASE-14468:
FAILURE: Integrated in HBase-0.98-matrix #283 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086059#comment-15086059
]
Lars Hofhansl commented on HBASE-14468:
---
bq. HBASE-10141. Not sure if it is in 0.98.
That's in
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086102#comment-15086102
]
Vladimir Rodionov commented on HBASE-14468:
---
{quote}
Vladimir Rodionov, any change to try the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086210#comment-15086210
]
Lars Hofhansl commented on HBASE-14468:
---
Hmm... We have the CompactionChecker in the RS, which
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15086198#comment-15086198
]
Vladimir Rodionov commented on HBASE-14468:
---
Verified test with short
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083558#comment-15083558
]
Vladimir Rodionov commented on HBASE-14468:
---
Looking into this.
> Compaction improvements:
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083584#comment-15083584
]
Vladimir Rodionov commented on HBASE-14468:
---
The bug [~lhofhansl] found does not allow setting
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083615#comment-15083615
]
Vladimir Rodionov commented on HBASE-14468:
---
[~lhofhansl]
{quote}
Lastly, does this require
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083657#comment-15083657
]
Vladimir Rodionov commented on HBASE-14468:
---
[~lhofhansl]
I think you should backport
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084618#comment-15084618
]
Vladimir Rodionov commented on HBASE-14468:
---
{quote}
Is there something else besides this patch
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084593#comment-15084593
]
Hudson commented on HBASE-14468:
SUCCESS: Integrated in HBase-1.3-IT #421 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084938#comment-15084938
]
Hudson commented on HBASE-14468:
SUCCESS: Integrated in HBase-1.2-IT #379 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084931#comment-15084931
]
Hudson commented on HBASE-14468:
FAILURE: Integrated in HBase-Trunk_matrix #612 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085018#comment-15085018
]
Hudson commented on HBASE-14468:
SUCCESS: Integrated in HBase-1.2 #490 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083931#comment-15083931
]
Vladimir Rodionov commented on HBASE-14468:
---
{quote}
Sorry for the spam here. I tested the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15083967#comment-15083967
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084001#comment-15084001
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084015#comment-15084015
]
Vladimir Rodionov commented on HBASE-14468:
---
Addendum is ready to be committed (2.0, 1.2, 1.3).
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084059#comment-15084059
]
Lars Hofhansl commented on HBASE-14468:
---
That's different. I see that as I flush at the time of
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084061#comment-15084061
]
Lars Hofhansl commented on HBASE-14468:
---
+1 on addendum.
> Compaction improvements: FIFO
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084099#comment-15084099
]
Lars Hofhansl commented on HBASE-14468:
---
Pushed addendum to 1.2, 1.3, and 2.0
> Compaction
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15084541#comment-15084541
]
Hudson commented on HBASE-14468:
SUCCESS: Integrated in HBase-1.3 #481 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082378#comment-15082378
]
Lars Hofhansl commented on HBASE-14468:
---
Yeah... Will commit today or early tomorrow.
> Compaction
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082200#comment-15082200
]
Andrew Purtell commented on HBASE-14468:
bq. here's a 0.98 patch
+1
Want to commit it?
>
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082514#comment-15082514
]
Lars Hofhansl commented on HBASE-14468:
---
Lastly, does this require HBASE-14467 as well?
>
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082522#comment-15082522
]
Lars Hofhansl commented on HBASE-14468:
---
One more: Should we recommend increasing
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082473#comment-15082473
]
stack commented on HBASE-14468:
---
Yeah. It looks wrong (And it should be if (! and drop that == false).
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082566#comment-15082566
]
Lars Hofhansl commented on HBASE-14468:
---
Sorry for the spam here. I tested the following scenario:
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082479#comment-15082479
]
Lars Hofhansl commented on HBASE-14468:
---
And (cosmetic) majorCompactionPeriod and
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082532#comment-15082532
]
Lars Hofhansl commented on HBASE-14468:
---
Example shell command:
{code}
create 'x',{NAME=>'y',
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082464#comment-15082464
]
Lars Hofhansl commented on HBASE-14468:
---
Actually there's a bug in
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15075680#comment-15075680
]
Vladimir Rodionov commented on HBASE-14468:
---
{quote}
here's a 0.98 patch
{quote}
Thanks,
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15074732#comment-15074732
]
Lars Hofhansl commented on HBASE-14468:
---
This is almost strictly add-on. We can backport to 0.98 I
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057000#comment-15057000
]
Vladimir Rodionov commented on HBASE-14468:
---
OK, [~enis]. I will open JIRA.
> Compaction
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056979#comment-15056979
]
Vladimir Rodionov commented on HBASE-14468:
---
{quote}
Seems ChoreService.shutdown() should be
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057022#comment-15057022
]
Vladimir Rodionov commented on HBASE-14468:
---
HBASE-14977.
> Compaction improvements: FIFO
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056992#comment-15056992
]
Enis Soztutar commented on HBASE-14468:
---
I think the issue is that the HashMaps inside ChoreService
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056833#comment-15056833
]
Vladimir Rodionov commented on HBASE-14468:
---
Another observation:
It fails under 1.8. My
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056829#comment-15056829
]
Vladimir Rodionov commented on HBASE-14468:
---
[~saint@gmail.com]
I see this exception
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056893#comment-15056893
]
Vladimir Rodionov commented on HBASE-14468:
---
Run test multiple times under 1.8_65. No issues.
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15056929#comment-15056929
]
Enis Soztutar commented on HBASE-14468:
---
Seems {{ChoreService.shutdown()}} should be
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15052188#comment-15052188
]
stack commented on HBASE-14468:
---
Any chance to look at above? Thanks.
> Compaction improvements: FIFO
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15049310#comment-15049310
]
stack commented on HBASE-14468:
---
This test hung just now in a 1.3 build:
kalashnikov:hbase.git stack$
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013118#comment-15013118
]
Hudson commented on HBASE-14468:
FAILURE: Integrated in HBase-Trunk_matrix #480 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15014251#comment-15014251
]
Vladimir Rodionov commented on HBASE-14468:
---
Created separate documentation JIRA: HBASE-14847.
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15012960#comment-15012960
]
Hudson commented on HBASE-14468:
FAILURE: Integrated in HBase-1.2 #384 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013022#comment-15013022
]
Hudson commented on HBASE-14468:
SUCCESS: Integrated in HBase-1.3-IT #322 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013028#comment-15013028
]
Hudson commented on HBASE-14468:
FAILURE: Integrated in HBase-1.3 #379 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15013092#comment-15013092
]
Hudson commented on HBASE-14468:
SUCCESS: Integrated in HBase-1.2-IT #292 (See
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15010064#comment-15010064
]
Hadoop QA commented on HBASE-14468:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997931#comment-14997931
]
Enis Soztutar commented on HBASE-14468:
---
Thanks for updating the patch. The changes look good. Only
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986255#comment-14986255
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986560#comment-14986560
]
Hadoop QA commented on HBASE-14468:
---
{color:green}+1 overall{color}. Here are the results of testing
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14981136#comment-14981136
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14979161#comment-14979161
]
Vladimir Rodionov commented on HBASE-14468:
---
[~enis]
* sanityCheck is OK, will do that
*
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14977632#comment-14977632
]
Enis Soztutar commented on HBASE-14468:
---
This is a good idea. We should add this to the list of
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14972017#comment-14972017
]
Devaraj Das commented on HBASE-14468:
-
[~vrodionov] the test still relies on real clocks.. It sleeps
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14970117#comment-14970117
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961618#comment-14961618
]
Devaraj Das commented on HBASE-14468:
-
Also consider usage of EnvironmentEdgeManager instead of
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14961608#comment-14961608
]
Devaraj Das commented on HBASE-14468:
-
Looks okay to me. The policy will address some use cases and
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944362#comment-14944362
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14944100#comment-14944100
]
Vladimir Rodionov commented on HBASE-14468:
---
In my local perf tests on my laptop I can easily
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942782#comment-14942782
]
Vladimir Rodionov commented on HBASE-14468:
---
{quote}
Yes, it looks like we can achieve FIFO
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940816#comment-14940816
]
Vladimir Rodionov commented on HBASE-14468:
---
HBASE-14477 - now its DateTieredCompaction :)
>
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939913#comment-14939913
]
Ted Yu commented on HBASE-14468:
I think support for purging expired files is already in code base.
If
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940214#comment-14940214
]
Vladimir Rodionov commented on HBASE-14468:
---
[~tedyu]
{quote}
think support for purging
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14940769#comment-14940769
]
Lars Hofhansl commented on HBASE-14468:
---
HBASE-14677 doesn't exist, though :)
> Compaction
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939307#comment-14939307
]
Lars Hofhansl commented on HBASE-14468:
---
The other thing I want to do is tired compactions along
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939217#comment-14939217
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939344#comment-14939344
]
Vladimir Rodionov commented on HBASE-14468:
---
There is a JIRA for that - HBASE-14677,
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14934776#comment-14934776
]
Lars Hofhansl commented on HBASE-14468:
---
Haven't looked at the patch, but the idea sounds great!
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935434#comment-14935434
]
Vladimir Rodionov commented on HBASE-14468:
---
Yes, FIFO compactor does only one job: collects
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935830#comment-14935830
]
Lars Hofhansl commented on HBASE-14468:
---
Thanks for background. We have some use cases with TTL,
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935917#comment-14935917
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14935982#comment-14935982
]
Vladimir Rodionov commented on HBASE-14468:
---
[~lhofhansl], I do not think FIFO is a good policy
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14909946#comment-14909946
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14910063#comment-14910063
]
Hadoop QA commented on HBASE-14468:
---
{color:red}-1 overall{color}. Here are the results of testing the
77 matches
Mail list logo