[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353360#comment-15353360
]
huaxiang sun commented on HBASE-14730:
--
HBASE-16137 is opened to track the findbug warning.
>
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353347#comment-15353347
]
huaxiang sun commented on HBASE-14730:
--
Will open a new jira to track.
> region server needs to log
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1535#comment-1535
]
stack commented on HBASE-14730:
---
This issue is closed now. Do a new issue?
> region server needs to log
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353316#comment-15353316
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] Thanks for explain. [~saint@gmail.com],
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352411#comment-15352411
]
Anoop Sam John commented on HBASE-14730:
With HFile V3, writing Tags to files will happen. It can
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352394#comment-15352394
]
stack commented on HBASE-14730:
---
Lads. This patch makes for a new findbugs warning:
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351943#comment-15351943
]
huaxiang sun commented on HBASE-14730:
--
Hi [~anoop.hbase], with HFile version 3, includesTags in
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337178#comment-15337178
]
Hudson commented on HBASE-14730:
SUCCESS: Integrated in HBase-1.3-IT #714 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337128#comment-15337128
]
Hudson commented on HBASE-14730:
FAILURE: Integrated in HBase-1.3 #744 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15337030#comment-15337030
]
Hudson commented on HBASE-14730:
FAILURE: Integrated in HBase-1.4 #222 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336818#comment-15336818
]
Mikhail Antonov commented on HBASE-14730:
-
I see - thanks!
> region server needs to log warnings
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336815#comment-15336815
]
huaxiang sun commented on HBASE-14730:
--
Hi [~mantonov], [~mbertozzi] just mentioned that a patch
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1533#comment-1533
]
Mikhail Antonov commented on HBASE-14730:
-
Pushed to branch-1 and branch-1.3 Thanks!
> region
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336659#comment-15336659
]
Mikhail Antonov commented on HBASE-14730:
-
It cherry-picked cleanly in b-1. let me commit it .
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336651#comment-15336651
]
huaxiang sun commented on HBASE-14730:
--
Yeah, it exists in b-1. Not sure if patch for branch-1.2
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336637#comment-15336637
]
Mikhail Antonov commented on HBASE-14730:
-
In b-1 there's HFileWriterV2.
> region server needs
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336632#comment-15336632
]
huaxiang sun commented on HBASE-14730:
--
Hi [~mantonov], in master and b-1, maybe b-1.3, there is no
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336589#comment-15336589
]
Mikhail Antonov commented on HBASE-14730:
-
[~anoop.hbase] [~huaxiang] that wasn't committed to
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15064226#comment-15064226
]
Hudson commented on HBASE-14730:
FAILURE: Integrated in HBase-1.0 #1124 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062070#comment-15062070
]
Anoop Sam John commented on HBASE-14730:
Patch looks good.
> region server needs to log warnings
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062351#comment-15062351
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] Thanks a lot for reviewing and the comments.
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062377#comment-15062377
]
Matteo Bertozzi commented on HBASE-14730:
-
sure, let me commit that now.
> region server needs
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062374#comment-15062374
]
Anoop Sam John commented on HBASE-14730:
[~mbertozzi] You will commit the patch?
> region
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062736#comment-15062736
]
Hudson commented on HBASE-14730:
FAILURE: Integrated in HBase-1.2-IT #348 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15062781#comment-15062781
]
Hudson commented on HBASE-14730:
FAILURE: Integrated in HBase-1.2 #451 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15063105#comment-15063105
]
Hudson commented on HBASE-14730:
FAILURE: Integrated in HBase-1.1-JDK8 #1710 (See
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060653#comment-15060653
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] I checked the master branch, the v2 writer is
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061029#comment-15061029
]
huaxiang sun commented on HBASE-14730:
--
Rename the patch so it can be picked up for branch-1.2.
>
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061030#comment-15061030
]
huaxiang sun commented on HBASE-14730:
--
Created HBASE-14995
> region server needs to log warnings
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060956#comment-15060956
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] With help from [~mbertozzi], we found the
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061026#comment-15061026
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15061323#comment-15061323
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}.
Test results:
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15034171#comment-15034171
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] [~mbertozzi] Thanks for reviewing and
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033725#comment-15033725
]
Anoop Sam John commented on HBASE-14730:
Yes IMO also warn log per flush seems too much. Already
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15033726#comment-15033726
]
Anoop Sam John commented on HBASE-14730:
The fix has to come for trunk also. There also one can
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032134#comment-15032134
]
Matteo Bertozzi commented on HBASE-14730:
-
is a warn per flush too often?
if we remove the
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15032169#comment-15032169
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15028059#comment-15028059
]
Hadoop QA commented on HBASE-14730:
---
{color:red}-1 overall{color}. Here are the results of testing the
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985641#comment-14985641
]
huaxiang sun commented on HBASE-14730:
--
[~anoop.hbase] Yes, I meant cell tags. That is the concern
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985874#comment-14985874
]
huaxiang sun commented on HBASE-14730:
--
Discussed with [~mbertozzi], Adding a flag in Writer can
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984775#comment-14984775
]
Anoop Sam John commented on HBASE-14730:
bq.When cells are flushed from memStore to Hfile,
[
https://issues.apache.org/jira/browse/HBASE-14730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984777#comment-14984777
]
Anoop Sam John commented on HBASE-14730:
Adding a log for every flush will be too much of log
42 matches
Mail list logo