[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186625#comment-15186625
]
stack commented on HBASE-15180:
---
The horrid names are fine by me. They are explicit and for internal use
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186406#comment-15186406
]
Anoop Sam John commented on HBASE-15180:
Ya to make sure the client uses only which it supposed
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186384#comment-15186384
]
Enis Soztutar commented on HBASE-15180:
---
The patch looks much cleaner than v4 I think.
Let's add
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186348#comment-15186348
]
Enis Soztutar commented on HBASE-15180:
---
bq. Dropped branch-1 based fixed versions. Adding new
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173573#comment-15173573
]
Hadoop QA commented on HBASE-15180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173243#comment-15173243
]
Anoop Sam John commented on HBASE-15180:
So in this patch made sure that on client side we wont
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160284#comment-15160284
]
stack commented on HBASE-15180:
---
Looks better to me. All the messing is kept internal to Codec.
Hopefully
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15160261#comment-15160261
]
Anoop Sam John commented on HBASE-15180:
wdyt of the latest patch [~saint@gmail.com], [~enis]
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153947#comment-15153947
]
Hadoop QA commented on HBASE-15180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153715#comment-15153715
]
Anoop Sam John commented on HBASE-15180:
Dropped branch-1 based fixed versions. Adding new
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153713#comment-15153713
]
Anoop Sam John commented on HBASE-15180:
bq.maybe it is best to cut to BB? Or, your Interface
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151398#comment-15151398
]
stack commented on HBASE-15180:
---
bq. Said that, continue with IS instead of a data structure like byte[]/BB
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151327#comment-15151327
]
Enis Soztutar commented on HBASE-15180:
---
bq. Yeah, best if could get away with not changing it but
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149962#comment-15149962
]
stack commented on HBASE-15180:
---
bq. Codec being non private if we add new methods, users may have to
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149932#comment-15149932
]
Anoop Sam John commented on HBASE-15180:
2 reasons why did not go that way
1. Codec being non
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149319#comment-15149319
]
stack commented on HBASE-15180:
---
bq. Maybe {{Codec}}s should be able to work on top of both IS and BBs
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149215#comment-15149215
]
Enis Soztutar commented on HBASE-15180:
---
HBASE-14501 removed {{IS.available()}} dependency for the
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149211#comment-15149211
]
stack commented on HBASE-15180:
---
s/remainAwareIS/reliableAvailable/ ?
Ok on the rest. Sounds good. If new
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148985#comment-15148985
]
Anoop Sam John commented on HBASE-15180:
bq.Is this flag saying we can rely on available() giving
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148960#comment-15148960
]
stack commented on HBASE-15180:
---
bq. I think a better question would be why the test coverage in
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148845#comment-15148845
]
Sean Busbey commented on HBASE-15180:
-
{quote}
bq. UT case TestTag is in the hbase-server module
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148222#comment-15148222
]
Anoop Sam John commented on HBASE-15180:
Ya the test code change looks fine.
> Reduce garbage
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148203#comment-15148203
]
Anoop Sam John commented on HBASE-15180:
Thanks for checking the test.. I will check that..
bq.
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148194#comment-15148194
]
Yu Li commented on HBASE-15180:
---
{{TestTags#testFlushAndCompactionWithoutTags}} will fail with the latest
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146976#comment-15146976
]
Anoop Sam John commented on HBASE-15180:
Ya my mistake in selecting Eclipse import suggestion ..
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146768#comment-15146768
]
Yu Li commented on HBASE-15180:
---
Below change in the v4 patch seems like some typo
{code}
+import
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15143139#comment-15143139
]
Hadoop QA commented on HBASE-15180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15130258#comment-15130258
]
Anoop Sam John commented on HBASE-15180:
Have a new patch ready but need change once HBASE-15177
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127259#comment-15127259
]
stack commented on HBASE-15180:
---
bq. Codec and its Decoder being non private, we can not directly change
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126122#comment-15126122
]
Jingcheng Du commented on HBASE-15180:
--
To supplement more information.
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126131#comment-15126131
]
Jingcheng Du commented on HBASE-15180:
--
And the gc pause was measured per minute.
> Reduce garbage
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127620#comment-15127620
]
Anoop Sam John commented on HBASE-15180:
bq.I see what you are saying. Rather than BAIS, instead
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15126709#comment-15126709
]
Esteban Gutierrez commented on HBASE-15180:
---
Good stuff [~jingcheng...@intel.com]. Very
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15125780#comment-15125780
]
Jingcheng Du commented on HBASE-15180:
--
bq. I believe Jingcheng Du done some YCSB test with writes
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124875#comment-15124875
]
stack commented on HBASE-15180:
---
bq. My plan is to make a Cell aware ByteArrayInputStream which can read
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124905#comment-15124905
]
Anoop Sam John commented on HBASE-15180:
Codec and its Decoder being non private, we can not
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124906#comment-15124906
]
Anoop Sam John commented on HBASE-15180:
bq.Can we ask our environment if we are on the
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124908#comment-15124908
]
Anoop Sam John commented on HBASE-15180:
bq.Yes, I noticed about 5-10% improvement on GC times
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15123913#comment-15123913
]
Hadoop QA commented on HBASE-15180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124586#comment-15124586
]
Anoop Sam John commented on HBASE-15180:
CellScanner - Ya we made it like normal our scanner way
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124771#comment-15124771
]
ramkrishna.s.vasudevan commented on HBASE-15180:
Renaming the interface is better +1 on
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124005#comment-15124005
]
Enis Soztutar commented on HBASE-15180:
---
bq. May be BB based then. Again am trying to experiment
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124024#comment-15124024
]
stack commented on HBASE-15180:
---
On MSLAB on all the time, there is talk of turning it off in G1GC because
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124036#comment-15124036
]
Esteban Gutierrez commented on HBASE-15180:
---
Yes, I noticed about 5-10% improvement on GC times
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124091#comment-15124091
]
Enis Soztutar commented on HBASE-15180:
---
bq. Yes, I noticed about 5-10% improvement on GC times and
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124141#comment-15124141
]
Esteban Gutierrez commented on HBASE-15180:
---
My guess at that time was that the rate the RSs
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124145#comment-15124145
]
stack commented on HBASE-15180:
---
bq. Even with G1, this is unexpected. Is there a theoretical explanation?
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124076#comment-15124076
]
Hadoop QA commented on HBASE-15180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124131#comment-15124131
]
stack commented on HBASE-15180:
---
Why not use Cell Codec for CellReadableByteArrayInputStream?
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122488#comment-15122488
]
Enis Soztutar commented on HBASE-15180:
---
This is a good idea. Having all cells in the same RPC
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15122878#comment-15122878
]
Anoop Sam John commented on HBASE-15180:
You mean to make Codec decoder to work over a byte[]
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120788#comment-15120788
]
Hadoop QA commented on HBASE-15180:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120736#comment-15120736
]
Ted Yu commented on HBASE-15180:
{code}
48public Cell readCell(boolean withTags) throws
[
https://issues.apache.org/jira/browse/HBASE-15180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120791#comment-15120791
]
Anoop Sam John commented on HBASE-15180:
bq.What does PB mean above ?
PushbackInputStream. We
54 matches
Mail list logo
