[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-17 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150168#comment-15150168 ] Heng Chen commented on HBASE-15267: --- Please see HBASE-15280 > Read requests count metric is increased

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-17 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150079#comment-15150079 ] Heng Chen commented on HBASE-15267: --- [~anoop.hbase] I have a question, if the table has only one

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150031#comment-15150031 ] Anoop Sam John commented on HBASE-15267: For Scan, readRequestsCount should be +1 on a next call

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150014#comment-15150014 ] Heng Chen commented on HBASE-15267: --- Sound reasonable. Yeah, whatever read and scan once we do

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149943#comment-15149943 ] Anoop Sam John commented on HBASE-15267: So we need fix such that this will consider both get and

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149854#comment-15149854 ] Heng Chen commented on HBASE-15267: --- I just see, in scan it calls {code:

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149851#comment-15149851 ] Anoop Sam John commented on HBASE-15267: Ya for scan case there is an update call as shown above.

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148388#comment-15148388 ] Heng Chen commented on HBASE-15267: --- I think i found the reason why scan ingore inexistent row, but

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-16 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148363#comment-15148363 ] Heng Chen commented on HBASE-15267: --- Oh! [~anoop.hbase] I found something interesting, readRequest

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148159#comment-15148159 ] Heng Chen commented on HBASE-15267: --- As for scan, it is impossible to visit an inexistent row. But

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148141#comment-15148141 ] Anoop Sam John commented on HBASE-15267: I see.. am not sure how that will happen.. A get is

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Eungsop Yoo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148108#comment-15148108 ] Eungsop Yoo commented on HBASE-15267: - Yes. The read requests count for Get and Scan are

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148107#comment-15148107 ] Heng Chen commented on HBASE-15267: --- I think Yoo's point is scan(d) ignore this request, so get(d)

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148100#comment-15148100 ] Anoop Sam John commented on HBASE-15267: For get "d" - Ya that is not a rk available.. Still why

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148064#comment-15148064 ] Heng Chen commented on HBASE-15267: --- Number looks good. > Read requests count metric is increased

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Eungsop Yoo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147955#comment-15147955 ] Eungsop Yoo commented on HBASE-15267: - Suppose that there are three rows, a, b and c(deleted but not

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147084#comment-15147084 ] Hadoop QA commented on HBASE-15267: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-14 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147004#comment-15147004 ] Anoop Sam John commented on HBASE-15267: That is being tracked by 'filteredReadRequestsCount'

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146897#comment-15146897 ] Hadoop QA commented on HBASE-15267: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-14 Thread Eungsop Yoo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146884#comment-15146884 ] Eungsop Yoo commented on HBASE-15267: - Currently (without this patch) Scan for not existing row does

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-14 Thread Eungsop Yoo (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146880#comment-15146880 ] Eungsop Yoo commented on HBASE-15267: - OK. My explanation was not enough. My intention was that how

[jira] [Commented] (HBASE-15267) Read requests count metric is increased when Get operation does not return any record

2016-02-14 Thread Elliott Clark (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15146829#comment-15146829 ] Elliott Clark commented on HBASE-15267: --- Seems like the metric is correct. It's all about how many