[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297873#comment-16297873
]
Hudson commented on HBASE-15482:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4257 (See
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297478#comment-16297478
]
Jerry He commented on HBASE-15482:
--
+1 on the latest patch.
> Provide an option to skip calculating
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297466#comment-16297466
]
Ted Yu commented on HBASE-15482:
lgtm
> Provide an option to skip calculating block locations for
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297150#comment-16297150
]
Hadoop QA commented on HBASE-15482:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297084#comment-16297084
]
Xiang Li commented on HBASE-15482:
--
Regarding the UT:
For mapred, the number of splits generated(=10) is
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16297060#comment-16297060
]
Xiang Li commented on HBASE-15482:
--
Hi [~tedyu], [~jerryhe], thanks for your comments and guide!
Patch
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287161#comment-16287161
]
Ted Yu commented on HBASE-15482:
With v3, the test needs some adjustment. Otherwise you would see:
{code}
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287092#comment-16287092
]
Xiang Li commented on HBASE-15482:
--
[~jerryhe], thanks very much for the comments. Got your idea.
Under
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285528#comment-16285528
]
Jerry He commented on HBASE-15482:
--
Hi, [~water]
In the 002 patch, you added 'numTopsAtMost' in
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285456#comment-16285456
]
Xiang Li commented on HBASE-15482:
--
I will upload a new patch to make some changes on UT, to address the
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285062#comment-16285062
]
Jerry He commented on HBASE-15482:
--
The patch looks good!
I just think the first patch 000 is cleaner.
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284998#comment-16284998
]
Ted Yu commented on HBASE-15482:
[~davelatham]:
Can you take another look ?
> Provide an option to skip
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284499#comment-16284499
]
Ted Yu commented on HBASE-15482:
lgtm
> Provide an option to skip calculating block locations for
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16284496#comment-16284496
]
Xiang Li commented on HBASE-15482:
--
[~tedyu], would you please help to review patch 002 at your
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283272#comment-16283272
]
Hadoop QA commented on HBASE-15482:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283093#comment-16283093
]
Hadoop QA commented on HBASE-15482:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283087#comment-16283087
]
Ted Yu commented on HBASE-15482:
You can choose the form which is intuitive to you.
> Provide an option
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283085#comment-16283085
]
Xiang Li commented on HBASE-15482:
--
Hi [~tedyu], thanks very much for the review and comment. I got your
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283043#comment-16283043
]
Ted Yu commented on HBASE-15482:
{code}
+ List locations = new ArrayList<>(Math.min(numTopsAtMost,
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283035#comment-16283035
]
Xiang Li commented on HBASE-15482:
--
[~tedyu], thanks very much for your comments!
patch 001 is updated
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281299#comment-16281299
]
Ted Yu commented on HBASE-15482:
{code}
+ public static final String
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281248#comment-16281248
]
Hadoop QA commented on HBASE-15482:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16280518#comment-16280518
]
Xiang Li commented on HBASE-15482:
--
[~davelatham], thanks very much for the comment and guide.
Uploaded
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16242203#comment-16242203
]
Dave Latham commented on HBASE-15482:
-
No, that will only stop using the locations. Need to prevent
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241965#comment-16241965
]
Xiang Li commented on HBASE-15482:
--
Hi [~liyintang], [~davelatham]
I planned to provide an option (the
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171033#comment-16171033
]
Xiang Li commented on HBASE-15482:
--
Thanks [~jerryhe]. Got it.
Just un-assign this JIRA. Joined the new
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164014#comment-16164014
]
Jerry He commented on HBASE-15482:
--
Hi, [~water] It is still relevant, Feel free to take it.
>
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162699#comment-16162699
]
Xiang Li commented on HBASE-15482:
--
Hi, this JIRA is still valid now? I plan to work on it if it is
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201910#comment-15201910
]
Nick Dimiduk commented on HBASE-15482:
--
Seems like this would apply for all the InputFormat
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202058#comment-15202058
]
churro morales commented on HBASE-15482:
I think Liyin is referring to only those InputFormats
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200994#comment-15200994
]
Ted Yu commented on HBASE-15482:
Welcome back, Liyin.
Yeah. This makes sense.
> Provide an option to
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202071#comment-15202071
]
Liyin Tang commented on HBASE-15482:
Yeah, that's right. Ideally, if SnapshotInputFormat can read
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202543#comment-15202543
]
Dave Latham commented on HBASE-15482:
-
Yes, I quite agree - we also skip it.
> Provide an option to
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202539#comment-15202539
]
Liyin Tang commented on HBASE-15482:
Dave, thanks for the response.
Even we use HDFS snapshots, it
[
https://issues.apache.org/jira/browse/HBASE-15482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202170#comment-15202170
]
Dave Latham commented on HBASE-15482:
-
Liyin, you mentioned it being outside of the scope of this
35 matches
Mail list logo
