[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903764#comment-15903764
]
stack commented on HBASE-15716:
---
Thanks for reviving this one [~vincentpoon]
> HRegion#RegionScannerImpl
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903597#comment-15903597
]
Vincent Poon commented on HBASE-15716:
--
I did a quick test with the patch here. Using hbase pe
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731545#comment-15731545
]
Yu Li commented on HBASE-15716:
---
Ping, this is something worth moving on according to our test result
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721718#comment-15721718
]
binlijin commented on HBASE-15716:
--
Looks like we can not use the patch for master version now?
Mvcc
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367838#comment-15367838
]
stack commented on HBASE-15716:
---
This is part of a project that is trying to remove all or most points of
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367503#comment-15367503
]
Lars Hofhansl commented on HBASE-15716:
---
What's the total (wall clock) runtime improvement? (just
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15367154#comment-15367154
]
Hiroshi Ikeda commented on HBASE-15716:
---
I realized I should have named the test class using the
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362226#comment-15362226
]
Hiroshi Ikeda commented on HBASE-15716:
---
bq. I should make getReadPoint private. It is only for use
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361997#comment-15361997
]
stack commented on HBASE-15716:
---
Let me upload a new patch w/ your changes included. A few comments on the
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361910#comment-15361910
]
stack commented on HBASE-15716:
---
[~ikeda] Pardon me. That backport was so we had parity with hadoop rpc. It
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361878#comment-15361878
]
Hiroshi Ikeda commented on HBASE-15716:
---
I found there is some changes on the master around this
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15361009#comment-15361009
]
Hiroshi Ikeda commented on HBASE-15716:
---
bq. You have tests that prove going backwards?
It is
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359682#comment-15359682
]
stack commented on HBASE-15716:
---
Can you make a patch [~ikeda]? I tried looking at HBASE-14479 and
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359023#comment-15359023
]
stack commented on HBASE-15716:
---
Thanks for finding these items [~ikeda] You have tests that prove going
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358754#comment-15358754
]
Hiroshi Ikeda commented on HBASE-15716:
---
That's bad. When there is no scanner, it is possible that
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358632#comment-15358632
]
Hiroshi Ikeda commented on HBASE-15716:
---
Sorry, I found that getSmallestReadPoint() may go backward
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358539#comment-15358539
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358441#comment-15358441
]
stack commented on HBASE-15716:
---
Issue that picks up some of the changes made in here but not committed as
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358399#comment-15358399
]
stack commented on HBASE-15716:
---
Ok. Changed my mind. The 005 patch has ONLY the [~ikeda] changes. I will
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358380#comment-15358380
]
stack commented on HBASE-15716:
---
I think it is fine. I went to hack on your class because I'd thought you'd
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358319#comment-15358319
]
Hiroshi Ikeda commented on HBASE-15716:
---
{code}
+ } // Otherwise head.references is
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358316#comment-15358316
]
Hiroshi Ikeda commented on HBASE-15716:
---
I meant, in Listener.doAccept, change
{code}
Reader reader
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358006#comment-15358006
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357027#comment-15357027
]
stack commented on HBASE-15716:
---
On the files, looks very nice. Let me try it and report back.
>
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357020#comment-15357020
]
stack commented on HBASE-15716:
---
This sounds interesting [~ikeda]. Let me see if I understand properly so I
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356363#comment-15356363
]
Hiroshi Ikeda commented on HBASE-15716:
---
Now I find the menu item "Attach Files". But I feel it
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355414#comment-15355414
]
stack commented on HBASE-15716:
---
I assigned the issue to you [~ikeda] as per [~yangzhe1991] suggestion.
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354603#comment-15354603
]
Hiroshi Ikeda commented on HBASE-15716:
---
I find I'm an administrator by the wheel icon, but still
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354601#comment-15354601
]
Phil Yang commented on HBASE-15716:
---
Try "assign to me" first, seems only assignee can attach files
>
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354592#comment-15354592
]
stack commented on HBASE-15716:
---
[~ikeda] I made you an administrator. Try now.
>
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354589#comment-15354589
]
stack commented on HBASE-15716:
---
You are logged in?
> HRegion#RegionScannerImpl scannerReadPoints
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354577#comment-15354577
]
Hiroshi Ikeda commented on HBASE-15716:
---
I still don't find a menu item or something to attach
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353752#comment-15353752
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353343#comment-15353343
]
stack commented on HBASE-15716:
---
[~ikeda] Try now. I added you to contributors (access to JIRA was shutdown
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352818#comment-15352818
]
Hiroshi Ikeda commented on HBASE-15716:
---
I tried some and created some tiny file but I just
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352604#comment-15352604
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352454#comment-15352454
]
stack commented on HBASE-15716:
---
Address comment up on rb.
Also add hashcode and equals to region and to
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352396#comment-15352396
]
stack commented on HBASE-15716:
---
Findbugs is because of recent commit on HBASE-14730. Pinged over there.
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352128#comment-15352128
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351709#comment-15351709
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351256#comment-15351256
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330047#comment-15330047
]
stack commented on HBASE-15716:
---
One note is that there is also registration of Store Scanners with the
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15316153#comment-15316153
]
stack commented on HBASE-15716:
---
Interesting observation was hacking out this lock, I ran then into my
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266144#comment-15266144
]
stack commented on HBASE-15716:
---
[~ikeda We continue conservative here, w/o change. I like your suggestion
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15266056#comment-15266056
]
Hiroshi Ikeda commented on HBASE-15716:
---
{code}
+ // If the isolation level is
[
https://issues.apache.org/jira/browse/HBASE-15716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262473#comment-15262473
]
Hadoop QA commented on HBASE-15716:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
46 matches
Mail list logo
