[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343761#comment-15343761
]
Hadoop QA commented on HBASE-16012:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343741#comment-15343741
]
Lars Hofhansl commented on HBASE-16012:
---
Thanks [~Apache9].
> Major compaction can't work because
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343650#comment-15343650
]
Hadoop QA commented on HBASE-16012:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343257#comment-15343257
]
Ted Yu commented on HBASE-16012:
[~carp84]:
You can commit the patch if you want.
> Major compaction
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343253#comment-15343253
]
Yu Li commented on HBASE-16012:
---
v5 lgtm, +1
> Major compaction can't work because left scanner read point
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343183#comment-15343183
]
Ted Yu commented on HBASE-16012:
Planning to integrate tomorrow morning, if there is no more review
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343171#comment-15343171
]
Guanghao Zhang commented on HBASE-16012:
Thanks Ted. Attach a v5 patch.
> Major compaction can't
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342421#comment-15342421
]
Yu Li commented on HBASE-16012:
---
Yes, this need to be rebased since HBASE-16032 already in, JFYI
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341778#comment-15341778
]
Ted Yu commented on HBASE-16012:
Please rebase the patch.
> Major compaction can't work because left
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340863#comment-15340863
]
Guanghao Zhang commented on HBASE-16012:
Yeah, the exception is thrown when initialize region
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340855#comment-15340855
]
Duo Zhang commented on HBASE-16012:
---
[~lhofhansl] The exception is thrown inside the constructor. We
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340782#comment-15340782
]
Lars Hofhansl commented on HBASE-16012:
---
Why is this not handled when the scanner's lease expires?
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340683#comment-15340683
]
Ted Yu commented on HBASE-16012:
v4 lgtm
> Major compaction can't work because left scanner read point
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333476#comment-15333476
]
Hadoop QA commented on HBASE-16012:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333068#comment-15333068
]
Hadoop QA commented on HBASE-16012:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333067#comment-15333067
]
Guanghao Zhang commented on HBASE-16012:
When new StoreScanner, it will seek scanner to the start
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15333006#comment-15333006
]
Allan Yang commented on HBASE-16012:
why not considered moving scannerReadPoints.put(this,
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332203#comment-15332203
]
Ted Yu commented on HBASE-16012:
The following test failure can be reproduced locally:
{code}
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331560#comment-15331560
]
Hadoop QA commented on HBASE-16012:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331438#comment-15331438
]
Guanghao Zhang commented on HBASE-16012:
Yes, if region not serving, the read point is no longer
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331430#comment-15331430
]
Jingcheng Du commented on HBASE-16012:
--
Thanks for patch Guanghao.
The smallest read point is
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331265#comment-15331265
]
Guanghao Zhang commented on HBASE-16012:
We should make sure that the scanner read point is
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331230#comment-15331230
]
Jingcheng Du commented on HBASE-16012:
--
Remove the changes in RSRpcServices? It seems we don't need
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331218#comment-15331218
]
Jingcheng Du commented on HBASE-16012:
--
bq. Yes, it should close the store scanner, too. But there
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15330730#comment-15330730
]
Guanghao Zhang commented on HBASE-16012:
The KeyValueScanner.close() doesn't throw exception, so
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329538#comment-15329538
]
Ted Yu commented on HBASE-16012:
{code}
+scannerReadPoints.remove(this);
{code}
Should the above
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15329534#comment-15329534
]
Ted Yu commented on HBASE-16012:
>From https://builds.apache.org/job/PreCommit-HBASE-Build/2200/console :
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328901#comment-15328901
]
Anoop Sam John commented on HBASE-16012:
There was one more scenario discussed in the mail chain.
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328869#comment-15328869
]
Guanghao Zhang commented on HBASE-16012:
Yes, it should close the store scanner, too. But there
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328865#comment-15328865
]
Jingcheng Du commented on HBASE-16012:
--
Thanks for the patch [~zghaobac].
If exceptions occur when
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15328862#comment-15328862
]
Ted Yu commented on HBASE-16012:
lgtm
> Major compaction can't work because left scanner read point in
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327278#comment-15327278
]
Jingcheng Du commented on HBASE-16012:
--
This issue is also in branch-1.x.
Thanks [~zghaobac], I can
[
https://issues.apache.org/jira/browse/HBASE-16012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327174#comment-15327174
]
ramkrishna.s.vasudevan commented on HBASE-16012:
I think the reasoning makes sense. Can
33 matches
Mail list logo
