[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408296#comment-15408296 ] Hudson commented on HBASE-16287: FAILURE: Integrated in HBase-1.2 #694 (See [https://bui

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408259#comment-15408259 ] Hudson commented on HBASE-16287: FAILURE: Integrated in HBase-1.4 #331 (See [https://bui

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408250#comment-15408250 ] Hudson commented on HBASE-16287: FAILURE: Integrated in HBase-1.3 #808 (See [https://bui

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407978#comment-15407978 ] Hudson commented on HBASE-16287: FAILURE: Integrated in HBase-Trunk_matrix #1353 (See [h

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407957#comment-15407957 ] Hudson commented on HBASE-16287: SUCCESS: Integrated in HBase-1.2-IT #572 (See [https://

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407906#comment-15407906 ] Hudson commented on HBASE-16287: SUCCESS: Integrated in HBase-1.3-IT #778 (See [https://

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407792#comment-15407792 ] Heng Chen commented on HBASE-16287: --- push to master and branch-1.2+ > LruBlockCache si

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407761#comment-15407761 ] Yu Sun commented on HBASE-16287: ok > LruBlockCache size should not exceed acceptableSiz

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407762#comment-15407762 ] Yu Sun commented on HBASE-16287: ok > LruBlockCache size should not exceed acceptableSiz

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407717#comment-15407717 ] Heng Chen commented on HBASE-16287: --- OK, I will commit it. > LruBlockCache size shoul

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407679#comment-15407679 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407670#comment-15407670 ] Anoop Sam John commented on HBASE-16287: +1 Nit : bq.if (currentSize > hardLimitS

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407658#comment-15407658 ] Anoop Sam John commented on HBASE-16287: Go for it in another issue. Thanks > Lr

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407613#comment-15407613 ] Heng Chen commented on HBASE-16287: --- +1 on patch v9 > LruBlockCache size should not ex

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407612#comment-15407612 ] Heng Chen commented on HBASE-16287: --- go on please. :) > LruBlockCache size should not

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407598#comment-15407598 ] Yu Sun commented on HBASE-16287: thanks for comments, v9 has fix this. BTW, I'd like to

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407574#comment-15407574 ] Heng Chen commented on HBASE-16287: --- Yeah, it is one issue. Let's fix it in another iss

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407476#comment-15407476 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-04 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407340#comment-15407340 ] Anoop Sam John commented on HBASE-16287: Nice reviews.. {code} if (!evictionInPro

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407274#comment-15407274 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407101#comment-15407101 ] Yu Sun commented on HBASE-16287: [~chenheng] Thanks for your reminding, yes,you are right

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407068#comment-15407068 ] Heng Chen commented on HBASE-16287: --- {quote} 1. calculate hardLimitSize in advance {quo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406969#comment-15406969 ] Yu Sun commented on HBASE-16287: thanks for [~yuzhih...@gmail.com] comments, yes, I will

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406359#comment-15406359 ] Ted Yu commented on HBASE-16287: {code} 376 if (currentSize > hardLimitSize) { {c

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406343#comment-15406343 ] Hadoop QA commented on HBASE-16287: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406175#comment-15406175 ] Yu Li commented on HBASE-16287: --- Thanks [~chenheng] for review, will wait one more day for

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-03 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406103#comment-15406103 ] Yu Sun commented on HBASE-16287: yes, I have tried this patch on some rs of our real clu

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-02 Thread Heng Chen (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405292#comment-15405292 ] Heng Chen commented on HBASE-16287: --- patch v5 lgtm. Have you try it on real cluster, c

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-08-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15404462#comment-15404462 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-31 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15401498#comment-15401498 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399213#comment-15399213 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-28 Thread Yu Sun (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15398623#comment-15398623 ] Yu Sun commented on HBASE-16287: will attach patch v3 after {{HBASE-16300}} commited, or

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397674#comment-15397674 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-28 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397194#comment-15397194 ] Yu Li commented on HBASE-16287: --- Current patch has some logic error and causing UT failure,

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397173#comment-15397173 ] Hadoop QA commented on HBASE-16287: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-27 Thread binlijin (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397009#comment-15397009 ] binlijin commented on HBASE-16287: -- Should we add metrics to record how many bytes of da

[jira] [Commented] (HBASE-16287) LruBlockCache size should not exceed acceptableSize too many

2016-07-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15395303#comment-15395303 ] Anoop Sam John commented on HBASE-16287: Ya it is related to speed of drain to BC