[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493999#comment-15493999
]
Yi Liang commented on HBASE-16381:
--
Thanks for committing [~chenheng] and thanks for reviewing
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493673#comment-15493673
]
Hudson commented on HBASE-16381:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #1606 (See
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493036#comment-15493036
]
Heng Chen commented on HBASE-16381:
---
Thanks [~easyliangjob] for your patch. Thanks [~jinghe] for your
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492032#comment-15492032
]
Jerry He commented on HBASE-16381:
--
Looks good. I like that option. Good work.
> Shell deleteall
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491904#comment-15491904
]
Heng Chen commented on HBASE-16381:
---
LGTM. +1
Will commit it if no other concerns.
> Shell deleteall
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491855#comment-15491855
]
Hadoop QA commented on HBASE-16381:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15489035#comment-15489035
]
Heng Chen commented on HBASE-16381:
---
{quote}
+ if list.size >= 100
+ @table.delete(list)
+
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488502#comment-15488502
]
Hadoop QA commented on HBASE-16381:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15488278#comment-15488278
]
Yi Liang commented on HBASE-16381:
--
yes, i will change it to reuse this list
> Shell deleteall command
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15486311#comment-15486311
]
Jerry He commented on HBASE-16381:
--
{code}
+if list.size >= 100
+ @table.delete(list)
+
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15485657#comment-15485657
]
Hadoop QA commented on HBASE-16381:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479321#comment-15479321
]
Heng Chen commented on HBASE-16381:
---
Sounds good to me
> Shell deleteall command should support row
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15479270#comment-15479270
]
Yi Liang commented on HBASE-16381:
--
yes, when we want to delete multiple rows, we just need to replace
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478931#comment-15478931
]
Heng Chen commented on HBASE-16381:
---
So if we want to operate on all rows with 'deleteall', we should
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15478469#comment-15478469
]
Jerry He commented on HBASE-16381:
--
Patch looks good.
Could you add a test in the hbase shell tests?
>
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477885#comment-15477885
]
Hadoop QA commented on HBASE-16381:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15477676#comment-15477676
]
Yi Liang commented on HBASE-16381:
--
yes, agree with Jerry. You can see from below code, the delete also
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472742#comment-15472742
]
Jerry He commented on HBASE-16381:
--
{noformat}
hbase(main):002:0> deleteall
ERROR: wrong number of
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472631#comment-15472631
]
Heng Chen commented on HBASE-16381:
---
As contact of "deleteall", it is used for one row for all
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472611#comment-15472611
]
Jerry He commented on HBASE-16381:
--
My feeling is that overloading the deleteall (option 2) is good
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436183#comment-15436183
]
Heng Chen commented on HBASE-16381:
---
IMO use another command is a good choice.
If we use deleteall,
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15436012#comment-15436012
]
Yi Liang commented on HBASE-16381:
--
ping [~tedyu] [~chenheng] [~apurtell] [~stack], could you guys take
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435342#comment-15435342
]
Hadoop QA commented on HBASE-16381:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435274#comment-15435274
]
Yi Liang commented on HBASE-16381:
--
V2 fix some warnings and format issues.
> Shell deleteall command
[
https://issues.apache.org/jira/browse/HBASE-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424978#comment-15424978
]
Yi Liang commented on HBASE-16381:
--
Hi [~apurtell],
I am now working on this jira, I think we had
25 matches
Mail list logo
