[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425310#comment-15425310
]
Dima Spivak commented on HBASE-16384:
-
Well FWIW, the only issue I cared about was the import order
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425303#comment-15425303
]
Sean Busbey commented on HBASE-16384:
-
+1. I agree that a clean-up follow-on is the way to go for the
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425276#comment-15425276
]
Appy commented on HBASE-16384:
--
Net pylint from patch are -ve, i.e. it's fixing a lot of old ones.
The net
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425245#comment-15425245
]
Dima Spivak commented on HBASE-16384:
-
You got a few more Pylint warnings with your newest patch,
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425234#comment-15425234
]
Appy commented on HBASE-16384:
--
Thanks Dima for reviewing it a couple of times yesterday night!
Need to get
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424135#comment-15424135
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424095#comment-15424095
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423977#comment-15423977
]
Appy commented on HBASE-16384:
--
bq.Order imports alphabetically, but grouped as described in PEP 8.
The
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423641#comment-15423641
]
Dima Spivak commented on HBASE-16384:
-
Thanks for updating the script, [~appy]; way more readable
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421770#comment-15421770
]
Appy commented on HBASE-16384:
--
[~busbey], [~dimaspivak] ready for final review.
> Update report-flakies.py
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421767#comment-15421767
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421724#comment-15421724
]
Appy commented on HBASE-16384:
--
installed pylint locally to see full set of warnings (instead of just patch
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421562#comment-15421562
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421504#comment-15421504
]
Appy commented on HBASE-16384:
--
Ahh, my python isn't the best and it felt like python was being very picky
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421212#comment-15421212
]
Sean Busbey commented on HBASE-16384:
-
bq. -1 pylint 0m 6s The patch generated 9 new + 23
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416279#comment-15416279
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416254#comment-15416254
]
Appy commented on HBASE-16384:
--
:)
Updated the patch as [~dimaspivak] suggested.
> Update report-flakies.py
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416090#comment-15416090
]
stack commented on HBASE-16384:
---
[~appy] [~dimaspivak] said pretty please. You going to refuse him?
>
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414470#comment-15414470
]
Dima Spivak commented on HBASE-16384:
-
Just as an example of what I'm proposing instead:
{noformat}
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414441#comment-15414441
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414400#comment-15414400
]
Dima Spivak commented on HBASE-16384:
-
I guess I'd take the order mattering over this confusing
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414366#comment-15414366
]
Appy commented on HBASE-16384:
--
I did consider that case in the starting. So basically it's,
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414351#comment-15414351
]
Dima Spivak commented on HBASE-16384:
-
In that case, how about use {{action='append'}} style
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414359#comment-15414359
]
Hadoop QA commented on HBASE-16384:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414344#comment-15414344
]
Appy commented on HBASE-16384:
--
Sorry for bad urls in example. But in practice, there will always be
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414337#comment-15414337
]
Dima Spivak commented on HBASE-16384:
-
Do we really invoke the script multiple times across different
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414333#comment-15414333
]
Appy commented on HBASE-16384:
--
So basically consider this example:
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414330#comment-15414330
]
Dima Spivak commented on HBASE-16384:
-
Why not just pass in a single URL and take separate arguments
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414325#comment-15414325
]
Appy commented on HBASE-16384:
--
Emm, is there any other option here that am missing? If it's better, and
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414320#comment-15414320
]
Dima Spivak commented on HBASE-16384:
-
As I said, it's just super hard to read; I can barely even
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414316#comment-15414316
]
Appy commented on HBASE-16384:
--
I know it's weird, but splitting into multiple options seemed more messy to
[
https://issues.apache.org/jira/browse/HBASE-16384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414304#comment-15414304
]
Dima Spivak commented on HBASE-16384:
-
Hey [~appy], this is a good change to make, but this is a
32 matches
Mail list logo
