[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427244#comment-16427244
]
stack commented on HBASE-16635:
---
FYI: Got pushed w/ wrong JIRA ID
commit
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502882#comment-15502882
]
Hadoop QA commented on HBASE-16635:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502654#comment-15502654
]
Duo Zhang commented on HBASE-16635:
---
+1.
There are still some bad practices but not your fault. I will
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502521#comment-15502521
]
Duo Zhang commented on HBASE-16635:
---
The connect method will called when you call Bootstrap.connect. So
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502483#comment-15502483
]
Hadoop QA commented on HBASE-16635:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502474#comment-15502474
]
ramkrishna.s.vasudevan commented on HBASE-16635:
Thanks for the comments. I was reading
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502428#comment-15502428
]
Duo Zhang commented on HBASE-16635:
---
Ah we should override the close method, not disconnect, sorry...
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502380#comment-15502380
]
Duo Zhang commented on HBASE-16635:
---
{quote}
so you mean all the ByteBuf in the queue has to removed in
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502368#comment-15502368
]
ramkrishna.s.vasudevan commented on HBASE-16635:
bq.The cleanupConnection does not need
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502335#comment-15502335
]
Duo Zhang commented on HBASE-16635:
---
The cleanupConnection does not need to throw Exception as the
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502304#comment-15502304
]
ramkrishna.s.vasudevan commented on HBASE-16635:
Tested the patch. I could not get that
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15495734#comment-15495734
]
ramkrishna.s.vasudevan commented on HBASE-16635:
Thanks [~Apache9]
Yes in the above
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493276#comment-15493276
]
Duo Zhang commented on HBASE-16635:
---
Go for it!
And some background, we can not release the ByteBufs
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15493041#comment-15493041
]
ramkrishna.s.vasudevan commented on HBASE-16635:
Thanks [~Apache9]
I think your guess i
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492619#comment-15492619
]
Duo Zhang commented on HBASE-16635:
---
Ah after a careful review, I found some leaks...
First is in
[
https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15492474#comment-15492474
]
Duo Zhang commented on HBASE-16635:
---
Can you add the -Dio.netty.leakDetection.level=advanced options
16 matches
Mail list logo
