[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712069#comment-15712069
]
Hudson commented on HBASE-17114:
SUCCESS: Integrated in Jenkins build HBase-1.4 #555 (See
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711797#comment-15711797
]
Hudson commented on HBASE-17114:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2052 (See
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711181#comment-15711181
]
Hadoop QA commented on HBASE-17114:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710985#comment-15710985
]
Yu Li commented on HBASE-17114:
---
Pushed into master branch. Thanks all for review [~ghelmling]
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710979#comment-15710979
]
Yu Li commented on HBASE-17114:
---
Thanks for the confirmation sir, committing now (smile).
> Add an option
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710960#comment-15710960
]
Anoop Sam John commented on HBASE-17114:
Apart from those 2 I was +1 :-) Go for commit.
> Add
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15710770#comment-15710770
]
Yu Li commented on HBASE-17114:
---
Ok, let me commit this one if no more comments/objections (smile).
> Add
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708779#comment-15708779
]
Yu Li commented on HBASE-17114:
---
[~anoop.hbase], does the v5 patch look good to you? Thanks.
> Add an
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708672#comment-15708672
]
Hadoop QA commented on HBASE-17114:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708527#comment-15708527
]
Yu Li commented on HBASE-17114:
---
Both nice catch sir, thanks for review. [~anoop.hbase]
Will add the check
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708248#comment-15708248
]
Anoop Sam John commented on HBASE-17114:
bq.Set this property to a higher value than
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707602#comment-15707602
]
Hadoop QA commented on HBASE-17114:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15707427#comment-15707427
]
Hadoop QA commented on HBASE-17114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704136#comment-15704136
]
Yu Li commented on HBASE-17114:
---
Thanks for review [~ghelmling], will add the config/description in
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703756#comment-15703756
]
Gary Helmling commented on HBASE-17114:
---
+1 on patch v2.
Please add an entry for this new config,
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702370#comment-15702370
]
Yu Li commented on HBASE-17114:
---
Ping, need some review comments here, thanks. :-)
> Add an option to set
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695563#comment-15695563
]
Yu Li commented on HBASE-17114:
---
UT looks good, mind take a look at the v2 patch [~ghelmling] and others?
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15695289#comment-15695289
]
Hadoop QA commented on HBASE-17114:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677377#comment-15677377
]
Yu Li commented on HBASE-17114:
---
bq. For advanced users who really need to treat CQTBE differently, that
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677310#comment-15677310
]
Yu Li commented on HBASE-17114:
---
All points on current patch makes sense to me, let me update the patch.
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677304#comment-15677304
]
Gary Helmling commented on HBASE-17114:
---
bq. Well, if checking the uploaded patch, it's indeed tied
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677228#comment-15677228
]
Gary Helmling commented on HBASE-17114:
---
-1 to the current patch:
* by default, retries of CQTBE
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15675588#comment-15675588
]
Yu Li commented on HBASE-17114:
---
bq. Another approach to this would be to allow the server to hint back to
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674690#comment-15674690
]
Gary Helmling commented on HBASE-17114:
---
bq. AFAICS we're already doing this in
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672662#comment-15672662
]
Yu Li commented on HBASE-17114:
---
Thanks [~ghelmling] for the feedback and [~tedyu]/[~zghaobac] for chiming
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672425#comment-15672425
]
Guanghao Zhang commented on HBASE-17114:
bq. Another approach to this would be to allow the
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672372#comment-15672372
]
Ted Yu commented on HBASE-17114:
bq. the multiplier received by the client represents the server state at
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15672280#comment-15672280
]
Gary Helmling commented on HBASE-17114:
---
The new CoDel may help in successfully processing more
[
https://issues.apache.org/jira/browse/HBASE-17114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15670891#comment-15670891
]
Yu Li commented on HBASE-17114:
---
As it's already late night on my site, will upload the patch tomorrow.
29 matches
Mail list logo
