[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999294#comment-15999294
]
stack commented on HBASE-17263:
---
Running on cluster now. Looks good [~aoxiang]. Its a bit noisy in the logs
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999273#comment-15999273
]
Hudson commented on HBASE-17263:
FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #223 (See
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997960#comment-15997960
]
binlijin commented on HBASE-17263:
--
{quote}
And [~aoxiang] please fill the release note later when you
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997955#comment-15997955
]
binlijin commented on HBASE-17263:
--
Thanks all for the review and commit.
> Netty based rpc server
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995165#comment-15995165
]
Hudson commented on HBASE-17263:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2943 (See
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994519#comment-15994519
]
Duo Zhang commented on HBASE-17263:
---
Let me help committing.
> Netty based rpc server impl
>
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992386#comment-15992386
]
Anoop Sam John commented on HBASE-17263:
The default is not changing by this patch. +1. Lets
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984367#comment-15984367
]
Duo Zhang commented on HBASE-17263:
---
So let's commit? [~stack] [~carp84] [~aoxiang].
Thanks.
> Netty
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984299#comment-15984299
]
Duo Zhang commented on HBASE-17263:
---
{quote}
Does patch v8 work on secure cluster ?
{quote}
I think
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984271#comment-15984271
]
stack commented on HBASE-17263:
---
Makes sense [~Apache9] I'm on the AMv2 these times on cluster. Could try
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15984188#comment-15984188
]
Hadoop QA commented on HBASE-17263:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983978#comment-15983978
]
Ted Yu commented on HBASE-17263:
Does patch v8 work on secure cluster ?
Thanks
> Netty based rpc
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983965#comment-15983965
]
Duo Zhang commented on HBASE-17263:
---
[~stack] For me I'd like to do some refactoring to split the big
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982478#comment-15982478
]
stack commented on HBASE-17263:
---
Agree on commit. What we have to do to make this default?
> Netty based
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980615#comment-15980615
]
Duo Zhang commented on HBASE-17263:
---
Skimmed on RB. No big questions. I think we can commit it first
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978836#comment-15978836
]
Hadoop QA commented on HBASE-17263:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978435#comment-15978435
]
ramkrishna.s.vasudevan commented on HBASE-17263:
[~aoxiang]
Sorry about putting this on
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978446#comment-15978446
]
Duo Zhang commented on HBASE-17263:
---
Will take a look soon.
> Netty based rpc server impl
>
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15874234#comment-15874234
]
binlijin commented on HBASE-17263:
--
ping [~anoop.hbase] [~ram_krish]
> Netty based rpc server impl
>
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857934#comment-15857934
]
Hadoop QA commented on HBASE-17263:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857666#comment-15857666
]
Hadoop QA commented on HBASE-17263:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823872#comment-15823872
]
Hadoop QA commented on HBASE-17263:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823564#comment-15823564
]
Hadoop QA commented on HBASE-17263:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823466#comment-15823466
]
Hadoop QA commented on HBASE-17263:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818131#comment-15818131
]
Hadoop QA commented on HBASE-17263:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817628#comment-15817628
]
binlijin commented on HBASE-17263:
--
{quote}
For NettyRpcServer , check the state of closed at the
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15817612#comment-15817612
]
binlijin commented on HBASE-17263:
--
Test the performance with LengthFieldBasedFrameDecoder, looks like
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816521#comment-15816521
]
Ted Yu commented on HBASE-17263:
For NettyRpcServer , check the state of closed at the beginning of
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15816434#comment-15816434
]
Ted Yu commented on HBASE-17263:
Mind putting patch on review board ?
> Netty based rpc server impl
>
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814557#comment-15814557
]
Duo Zhang commented on HBASE-17263:
---
That's what I mean 'netty style'. Separate logics into different
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814542#comment-15814542
]
binlijin commented on HBASE-17263:
--
Let me try LengthFieldBasedFrameDecoder, i do not remember the
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814523#comment-15814523
]
Duo Zhang commented on HBASE-17263:
---
And I think this will increase latency while increasing
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814515#comment-15814515
]
Duo Zhang commented on HBASE-17263:
---
Then you can just implement a BatchingHandler and place it after
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814504#comment-15814504
]
binlijin commented on HBASE-17263:
--
See http://bluedavy.me/?p=384
3、65k –> 88k
> Netty based rpc
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814501#comment-15814501
]
Duo Zhang commented on HBASE-17263:
---
I think the decoder will always be excuted in the same event loop
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814490#comment-15814490
]
binlijin commented on HBASE-17263:
--
For performance reason, every time NettyProtocolDecoder decodes
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814455#comment-15814455
]
Duo Zhang commented on HBASE-17263:
---
I'd say the code is really not netty style...
And I think our
[
https://issues.apache.org/jira/browse/HBASE-17263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724932#comment-15724932
]
Ted Yu commented on HBASE-17263:
Can you fill out description ?
> Netty based rpc server impl
>
38 matches
Mail list logo
