[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884564#comment-15884564
]
Appy commented on HBASE-17312:
--
Thanks [~stack] and [~zyork] for the reviews.
> [JDK8] Use default method
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884283#comment-15884283
]
Hudson commented on HBASE-17312:
SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2569 (See
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884188#comment-15884188
]
Appy commented on HBASE-17312:
--
Two test failures are unrelated. Ran them locally and they passed.
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15884028#comment-15884028
]
Hadoop QA commented on HBASE-17312:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882674#comment-15882674
]
Hadoop QA commented on HBASE-17312:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882080#comment-15882080
]
Hadoop QA commented on HBASE-17312:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880658#comment-15880658
]
Hadoop QA commented on HBASE-17312:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879741#comment-15879741
]
Zach York commented on HBASE-17312:
---
[~appy] I had some comments, mostly minor. Thanks!
> [JDK8] Use
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879288#comment-15879288
]
Appy commented on HBASE-17312:
--
Thanks [~stack] for the review. Replied to comments in RB.
Waiting today if
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879265#comment-15879265
]
stack commented on HBASE-17312:
---
+1 This is excellent cleanup. A few small things in rb that can go in on
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877648#comment-15877648
]
Appy commented on HBASE-17312:
--
Ping. Requesting review :)
I have a follow-up design simplification for
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873216#comment-15873216
]
Hadoop QA commented on HBASE-17312:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873096#comment-15873096
]
Appy commented on HBASE-17312:
--
Uploaded the new patch (002) and added RB link.
> [JDK8] Use default method
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873092#comment-15873092
]
Appy commented on HBASE-17312:
--
In that case, i'll try to see it through.
Will upload new patch and RB
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872907#comment-15872907
]
huzheng commented on HBASE-17312:
-
Hi [~appy]
[~zghaobac] is on vacation this days, so go ahead. :)
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872540#comment-15872540
]
Appy commented on HBASE-17312:
--
If you want [~zghaobac], i can take up this work. I have a patch which also
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871048#comment-15871048
]
Appy commented on HBASE-17312:
--
So answering [~stack]'s question above:
Right now we have
{noformat}
public
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870809#comment-15870809
]
Andrew Purtell commented on HBASE-17312:
No discussion needed. My answer is based on a lack of
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870811#comment-15870811
]
Zach York commented on HBASE-17312:
---
bq. Phoenix has no support for master branch and no development
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870784#comment-15870784
]
Enis Soztutar commented on HBASE-17312:
---
bq. Phoenix has no support for master branch and no
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870543#comment-15870543
]
Andrew Purtell commented on HBASE-17312:
Phoenix has no support for master branch and no
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869282#comment-15869282
]
stack commented on HBASE-17312:
---
[~appy] Want to describe what CPs will have to do to move to hbase-2.0.0,
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868999#comment-15868999
]
Sean Busbey commented on HBASE-17312:
-
ping [~apurtell] and [~enis]: any chance y'all could find
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868872#comment-15868872
]
Appy commented on HBASE-17312:
--
I would suggest deleting the Base...Observer classes since
- it's 2.0, we
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868861#comment-15868861
]
Appy commented on HBASE-17312:
--
Please post the patch on Review board so it's easy to review. Thanks
[
https://issues.apache.org/jira/browse/HBASE-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861053#comment-15861053
]
Hadoop QA commented on HBASE-17312:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
26 matches
Mail list logo
