[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783075#comment-15783075 ] Ted Yu commented on HBASE-17374: +1 on latest patch > ZKPermissionWatcher crashed when grant after close

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15782521#comment-15782521 ] Hadoop QA commented on HBASE-17374: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780688#comment-15780688 ] Hadoop QA commented on HBASE-17374: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780639#comment-15780639 ] Liu Junhong commented on HBASE-17374: - I notice that refreshAuthManager will call when a new

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780648#comment-15780648 ] Liu Junhong commented on HBASE-17374: - Actually I think it maybe better that TableAuthManager use

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780619#comment-15780619 ] Liu Junhong commented on HBASE-17374: - The data-probe-test is a table for crontab to test if the

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780556#comment-15780556 ] Ted Yu commented on HBASE-17374: Was the target of grant command the 'data-probe-test' table ? >

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780543#comment-15780543 ] Ted Yu commented on HBASE-17374: {code} 790 if (ref-1 <= 0 && shouldClose) { {code} When ref-1

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-27 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15780428#comment-15780428 ] Liu Junhong commented on HBASE-17374: - It is late now in Beijing , submit a path for discussion. I

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15779815#comment-15779815 ] Liu Junhong commented on HBASE-17374: - Thank you for your prompt. I will try it. >

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778484#comment-15778484 ] Ted Yu commented on HBASE-17374: You can add debug log in the ZKPermissionWatcher method, identifying the

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778231#comment-15778231 ] Hadoop QA commented on HBASE-17374: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778185#comment-15778185 ] Hadoop QA commented on HBASE-17374: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778080#comment-15778080 ] Ted Yu commented on HBASE-17374: The release() method does: {code}

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778078#comment-15778078 ] Liu Junhong commented on HBASE-17374: - But it is still strange for why

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778074#comment-15778074 ] Liu Junhong commented on HBASE-17374: - Oh, I understand your mean, I had a mistake. >

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778069#comment-15778069 ] Ted Yu commented on HBASE-17374: Junhong: Can you come up with a test which shows the defect in the

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778066#comment-15778066 ] Liu Junhong commented on HBASE-17374: - No seen it . > ZKPermissionWatcher crashed when grant after

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778060#comment-15778060 ] Ted Yu commented on HBASE-17374: {code} if (refCount.get(instance) == null || refCount.get(instance)

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778054#comment-15778054 ] Liu Junhong commented on HBASE-17374: - Reading and Changing the value of refCount is not atomicity.

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778050#comment-15778050 ] Liu Junhong commented on HBASE-17374: - Sorry for wrong description, i mean when cocurrent call

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778049#comment-15778049 ] Ted Yu commented on HBASE-17374: refCount is static. What's the difference between proposed fix and

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Liu Junhong (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778051#comment-15778051 ] Liu Junhong commented on HBASE-17374: - Sorry for wrong description, i mean when cocurrent call

[jira] [Commented] (HBASE-17374) ZKPermissionWatcher crashed when grant after close region

2016-12-26 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-17374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15778017#comment-15778017 ] Ted Yu commented on HBASE-17374: Can the problem be reproduced with 0.98.23 ? Does the proposed patch