[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167733#comment-16167733
]
Chia-Ping Tsai commented on HBASE-17980:
bq. Make UnmodifyableHRegionInfo IA.Private.
My bad.
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167250#comment-16167250
]
Chia-Ping Tsai commented on HBASE-17980:
bq. Mind making a list of what you'd like me to address
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167147#comment-16167147
]
Hudson commented on HBASE-17980:
FAILURE: Integrated in Jenkins build HBase-2.0 #514 (See
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167139#comment-16167139
]
Hudson commented on HBASE-17980:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3715 (See
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166967#comment-16166967
]
Hadoop QA commented on HBASE-17980:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166770#comment-16166770
]
stack commented on HBASE-17980:
---
.007 failure was legit. We were mangling the handling of read replicas of
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166132#comment-16166132
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165828#comment-16165828
]
stack commented on HBASE-17980:
---
.006 addes the IA.Private to Unmodifyable as per [~chia7712] and fixes the
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165802#comment-16165802
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165778#comment-16165778
]
Chia-Ping Tsai commented on HBASE-17980:
Make UnmodifyableHRegionInfo IA.Private. Other than
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165776#comment-16165776
]
stack commented on HBASE-17980:
---
.005 Fix unit test.
> Any HRegionInfo we give out should be immutable
>
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165728#comment-16165728
]
stack commented on HBASE-17980:
---
.004 is rebase
> Any HRegionInfo we give out should be immutable
>
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165710#comment-16165710
]
stack commented on HBASE-17980:
---
.003 is based on v6. It does below:
* Fixes broke tests by changing
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165707#comment-16165707
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165302#comment-16165302
]
stack commented on HBASE-17980:
---
I'm going through this patch now... Will factor in the above comment by
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165294#comment-16165294
]
Chia-Ping Tsai commented on HBASE-17980:
The failed tests is due to the wrong regionname of
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165172#comment-16165172
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165169#comment-16165169
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164941#comment-16164941
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164909#comment-16164909
]
stack commented on HBASE-17980:
---
@kuan-po tseng do what u think makes sense. It was in server because that
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164862#comment-16164862
]
Chia-Ping Tsai commented on HBASE-17980:
The RegionInfoDisplay only has the strange stuff in it,
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164851#comment-16164851
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164837#comment-16164837
]
Kuan-Po Tseng commented on HBASE-17980:
---
[~stack] Almost done. My last question is could
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164773#comment-16164773
]
Kuan-Po Tseng commented on HBASE-17980:
---
[~stack] I am now working on it. Could you give me some
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164756#comment-16164756
]
stack commented on HBASE-17980:
---
The reorder of RegionStates imports is my fault. I was adding the display
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164659#comment-16164659
]
Chia-Ping Tsai commented on HBASE-17980:
# correct the link in javadocs (you can run {{mvn clean
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164484#comment-16164484
]
Chia-Ping Tsai commented on HBASE-17980:
BTW, these IA.Private methods should be moved to an new
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164475#comment-16164475
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164422#comment-16164422
]
Chia-Ping Tsai commented on HBASE-17980:
I feel some helper methods which are used internally
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164304#comment-16164304
]
stack commented on HBASE-17980:
---
Compile on jenkins has this complaint:
[ERROR]
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164302#comment-16164302
]
stack commented on HBASE-17980:
---
[~chia7712] Yeah, that is a problem. Push back to protobufutils in client
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164288#comment-16164288
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164286#comment-16164286
]
Chia-Ping Tsai commented on HBASE-17980:
I don't want to make noise, but can Client Public APIs
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164268#comment-16164268
]
stack commented on HBASE-17980:
---
[~brandboat] I'm done. See .002. Its yours now. If you want to chat about
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164251#comment-16164251
]
stack commented on HBASE-17980:
---
[~brandboat] NP. Let me put up another that is further along. One sec.
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164247#comment-16164247
]
Kuan-Po Tseng commented on HBASE-17980:
---
[~stack] Yeah, I have time to take it on. But the file you
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164239#comment-16164239
]
stack commented on HBASE-17980:
---
[~brandboat] What I have been working on moving the static methods out of
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164232#comment-16164232
]
stack commented on HBASE-17980:
---
Let me put up what I have ... I've been hacking on it.
> Any HRegionInfo
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164177#comment-16164177
]
Kuan-Po Tseng commented on HBASE-17980:
---
[~stack] Are you alreday doing this stuff ? There are just
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164174#comment-16164174
]
Chia-Ping Tsai commented on HBASE-17980:
We have a issue to trace the timeout. You can just retry
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164154#comment-16164154
]
Kuan-Po Tseng commented on HBASE-17980:
---
[~chia7712] [~stack] Here is the review board
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163987#comment-16163987
]
Chia-Ping Tsai commented on HBASE-17980:
bq. I can make the patch np if you folks are busy
I can
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163918#comment-16163918
]
stack commented on HBASE-17980:
---
RegionInfoUtil is out-of-the-way. I hear you on too many methds. Let me
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163871#comment-16163871
]
Chia-Ping Tsai commented on HBASE-17980:
bq. Why not RegionInfo?
There are many of helper
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163854#comment-16163854
]
stack commented on HBASE-17980:
---
[~chia7712] Why not RegionInfo? I can make the patch np if you folks are
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163787#comment-16163787
]
Chia-Ping Tsai commented on HBASE-17980:
[~brandboat] Would you please put ur patch in [review
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163781#comment-16163781
]
Chia-Ping Tsai commented on HBASE-17980:
bq. ...to the RegionInfo Interface?
or RegionInfoUtil
>
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163770#comment-16163770
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163562#comment-16163562
]
stack commented on HBASE-17980:
---
[~brandboat] Ok if i move these static methods from RegionInfoBuilder to
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163528#comment-16163528
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163312#comment-16163312
]
Kuan-Po Tseng commented on HBASE-17980:
---
v2
- Rename UnmodifyableHRegionInfo.java to
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163067#comment-16163067
]
Chia-Ping Tsai commented on HBASE-17980:
I'm fine with getRegions :)
> Any HRegionInfo we give
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163066#comment-16163066
]
Kuan-Po Tseng commented on HBASE-17980:
---
[~stack] OK, I will leave closeRegion alone.
Then change
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163062#comment-16163062
]
Chia-Ping Tsai commented on HBASE-17980:
The "Online" in {{getOnlineRegions}} is redundant
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163048#comment-16163048
]
stack commented on HBASE-17980:
---
[~brandboat] Isn't closeRegion deprecated? So, just leave it?
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163038#comment-16163038
]
Kuan-Po Tseng commented on HBASE-17980:
---
Hello [~chia7712],
{code:java}
void closeRegion(final
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163012#comment-16163012
]
Chia-Ping Tsai commented on HBASE-17980:
[~brandboat] Replace the HRI by RI in Client Module
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162458#comment-16162458
]
Kuan-Po Tseng commented on HBASE-17980:
---
Sorry, I will submit another patch today or tomorrow.
>
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162271#comment-16162271
]
stack commented on HBASE-17980:
---
Any luck [~brandboat] Would be cool to get this into alpha3.
> Any
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159082#comment-16159082
]
Kuan-Po Tseng commented on HBASE-17980:
---
Copy that. Thanks for your advice~
> Any HRegionInfo we
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159071#comment-16159071
]
stack commented on HBASE-17980:
---
Good on #2.
On MutableRI being public, if only usage is delegation, then
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159008#comment-16159008
]
Kuan-Po Tseng commented on HBASE-17980:
---
Hello stack,
1. Yes, MutableRI is set to IA.Private.
2.
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158920#comment-16158920
]
stack commented on HBASE-17980:
---
[~brandboat] Can MutableRI be Audience Private? Can we get away with HRI
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158302#comment-16158302
]
Kuan-Po Tseng commented on HBASE-17980:
---
Hello stack,
Now I make MutableRegionInfo public is
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156016#comment-16156016
]
stack commented on HBASE-17980:
---
bq. I didn't change Admin Interface API in this patch, should I replace
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154878#comment-16154878
]
Kuan-Po Tseng commented on HBASE-17980:
---
Hello stack,
Now we have a Mutable(inside
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16154786#comment-16154786
]
stack commented on HBASE-17980:
---
Patch looks great.
I was going to suggest moving RegionInfo to
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152829#comment-16152829
]
Chia-Ping Tsai commented on HBASE-17980:
*fix:00*
{code}
+
+public class RegionInfoBuilder {
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152800#comment-16152800
]
Hadoop QA commented on HBASE-17980:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152710#comment-16152710
]
Hadoop QA commented on HBASE-17980:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151388#comment-16151388
]
stack commented on HBASE-17980:
---
That sounds good any other places.we.let out his.
> Any HRegionInfo we
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151339#comment-16151339
]
Kuan-Po Tseng commented on HBASE-17980:
---
Almost done. Now I am adding some tests.
But I have a
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151107#comment-16151107
]
stack commented on HBASE-17980:
---
Any luck w/ this one lads? Thanks.
> Any HRegionInfo we give out should
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125751#comment-16125751
]
Chia-Ping Tsai commented on HBASE-17980:
go ahead.
> Any HRegionInfo we give out should be
[
https://issues.apache.org/jira/browse/HBASE-17980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125746#comment-16125746
]
brandboat commented on HBASE-17980:
---
[~chia7712] Let me take over this issue.
> Any HRegionInfo we
75 matches
Mail list logo
