[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040241#comment-16040241
]
Hudson commented on HBASE-18145:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK7 #177 (See
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040214#comment-16040214
]
Hudson commented on HBASE-18145:
SUCCESS: Integrated in Jenkins build HBase-1.3-JDK8 #191 (See
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040138#comment-16040138
]
Hudson commented on HBASE-18145:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3149 (See
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040133#comment-16040133
]
Hudson commented on HBASE-18145:
SUCCESS: Integrated in Jenkins build HBase-1.4 #764 (See
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039996#comment-16039996
]
Hudson commented on HBASE-18145:
SUCCESS: Integrated in Jenkins build HBase-1.3-IT #59 (See
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039519#comment-16039519
]
Andrew Purtell commented on HBASE-18145:
Ok, committing shortly unless objection
> The flush may
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039073#comment-16039073
]
Chia-Ping Tsai commented on HBASE-18145:
In my view, these patch are ready to be committed.
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039066#comment-16039066
]
Chia-Ping Tsai commented on HBASE-18145:
The failed tests have passed locally.
> The flush may
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1603#comment-1603
]
Hadoop QA commented on HBASE-18145:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038529#comment-16038529
]
Hadoop QA commented on HBASE-18145:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037452#comment-16037452
]
Andrew Purtell commented on HBASE-18145:
I always run tests locally before committing, if that
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037453#comment-16037453
]
Andrew Purtell commented on HBASE-18145:
No problem to wait, as an alternative.
> The flush may
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037450#comment-16037450
]
Chia-Ping Tsai commented on HBASE-18145:
The patch for master is ready to go, but the patch for
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037440#comment-16037440
]
Andrew Purtell commented on HBASE-18145:
Looks like this is ready to go but not committed yet. I
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036509#comment-16036509
]
Anoop Sam John commented on HBASE-18145:
+1
> The flush may cause the corrupt data for reading
>
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036482#comment-16036482
]
Chia-Ping Tsai commented on HBASE-18145:
[~anoop.hbase] Any suggestions for v1.patch? Thanks.
>
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036481#comment-16036481
]
Chia-Ping Tsai commented on HBASE-18145:
The oracle-java7-installer has some problem. (ref:
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036477#comment-16036477
]
Hadoop QA commented on HBASE-18145:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036474#comment-16036474
]
Chia-Ping Tsai commented on HBASE-18145:
v1.patch
# correct the typo
# scannerForDelayedClose ->
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036363#comment-16036363
]
Hadoop QA commented on HBASE-18145:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16036308#comment-16036308
]
Chia-Ping Tsai commented on HBASE-18145:
The failed TestAcid* may caused by HBASE-18158. Let me
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035871#comment-16035871
]
Chia-Ping Tsai commented on HBASE-18145:
The TestAcid* still fails on my local run. 27/1000
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034252#comment-16034252
]
Chia-Ping Tsai commented on HBASE-18145:
bq. I was asking whether these 2 we can combine into
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034237#comment-16034237
]
Anoop Sam John commented on HBASE-18145:
I mean we already have a List of heaps for delayed
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034175#comment-16034175
]
Chia-Ping Tsai commented on HBASE-18145:
bq. withDelayedScannersClose?
okay.
bq. May be we need
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034165#comment-16034165
]
Anoop Sam John commented on HBASE-18145:
bq.How about this change? withHeapClose ->
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034155#comment-16034155
]
Chia-Ping Tsai commented on HBASE-18145:
All failed tests have passed on my local run.
> The
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034146#comment-16034146
]
Chia-Ping Tsai commented on HBASE-18145:
bq. In shipped() new call to
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034120#comment-16034120
]
Anoop Sam John commented on HBASE-18145:
Very imp finding..
In shipped() new call to
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033563#comment-16033563
]
Mikhail Antonov commented on HBASE-18145:
-
+1, nice catch.
Yep that needs to go to 1.3.2.
>
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033434#comment-16033434
]
Hadoop QA commented on HBASE-18145:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033323#comment-16033323
]
Andrew Purtell commented on HBASE-18145:
lgtm
Nice new test.
> The flush may cause the corrupt
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033253#comment-16033253
]
Chia-Ping Tsai commented on HBASE-18145:
The HBASE-17887 introduce this critical bug into the
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033239#comment-16033239
]
ramkrishna.s.vasudevan commented on HBASE-18145:
Nice one. Minor nit - it is 'chunk'. +1
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033130#comment-16033130
]
Chia-Ping Tsai commented on HBASE-18145:
bq. scannerForDelayedClose -> scannersForDelayedClose
[
https://issues.apache.org/jira/browse/HBASE-18145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033097#comment-16033097
]
Ted Yu commented on HBASE-18145:
lgtm
{code}
106 private final List scannerForDelayedClose = new
36 matches
Mail list logo
