[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219071#comment-16219071
]
Hudson commented on HBASE-18368:
FAILURE: Integrated in Jenkins build HBase-2.0 #748 (See
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16218762#comment-16218762
]
Hudson commented on HBASE-18368:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3948 (See
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210863#comment-16210863
]
Guanghao Zhang commented on HBASE-18368:
The failed ut in
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210862#comment-16210862
]
Guanghao Zhang commented on HBASE-18368:
+1.
> FilterList with multiple FamilyFilters
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209351#comment-16209351
]
Hadoop QA commented on HBASE-18368:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16209311#comment-16209311
]
Hadoop QA commented on HBASE-18368:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207704#comment-16207704
]
Hadoop QA commented on HBASE-18368:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16161214#comment-16161214
]
Peter Somogyi commented on HBASE-18368:
---
[~openinx], are you still working on this?
> FilterList
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125501#comment-16125501
]
Guanghao Zhang commented on HBASE-18368:
NEXT_ROW_IN_FAMILY is still not right. I thought the
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125490#comment-16125490
]
Zheng Hu commented on HBASE-18368:
--
Hi , Anyone help to review the patch v3 ? [~anoop.hbase],
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123216#comment-16123216
]
Hadoop QA commented on HBASE-18368:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123006#comment-16123006
]
Hadoop QA commented on HBASE-18368:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122953#comment-16122953
]
Guanghao Zhang commented on HBASE-18368:
bq. Actually, neither NEXT_ROW or NEXT_FAMILY could
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122939#comment-16122939
]
Zheng Hu commented on HBASE-18368:
--
So how about dividing the NEXT_ROW into two seperate return code ?
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122936#comment-16122936
]
Zheng Hu commented on HBASE-18368:
--
bq. Even the filter return a NEXT_ROW, it still may get a cell from
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122839#comment-16122839
]
Guanghao Zhang commented on HBASE-18368:
Even the filter return a NEXT_ROW, it still may get a
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122797#comment-16122797
]
Zheng Hu commented on HBASE-18368:
--
bq. How about we rename NEXT_ROW to NEXT_FAMILY directly?
I would
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122741#comment-16122741
]
Guanghao Zhang commented on HBASE-18368:
How about we rename NEXT_ROW to NEXT_FAMILY directly?
>
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121805#comment-16121805
]
Ted Yu commented on HBASE-18368:
FamilyFilter is in hbase-client module.
User can send FamilyFilter or
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121784#comment-16121784
]
Zheng Hu commented on HBASE-18368:
--
bq. This is an incompatible change, right ?
Actually, old version
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121752#comment-16121752
]
Ted Yu commented on HBASE-18368:
Peter, the patch was from Zheng Hu, not me.
> FilterList with multiple
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121656#comment-16121656
]
Peter Somogyi commented on HBASE-18368:
---
bq. This is an incompatible change, right ?
I believe it
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121642#comment-16121642
]
Ted Yu commented on HBASE-18368:
This is an incompatible change, right ?
> FilterList with multiple
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121566#comment-16121566
]
Hadoop QA commented on HBASE-18368:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120154#comment-16120154
]
Zheng Hu commented on HBASE-18368:
--
Fine, I'll get this finished. New patch will come soon.
>
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120071#comment-16120071
]
Allan Yang commented on HBASE-18368:
{quote}
Allan Yang, if you do not have time, I can try to fix
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120022#comment-16120022
]
Allan Yang commented on HBASE-18368:
{quote}
Do you have time to resume the work here ?
{quote}
Kind
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120015#comment-16120015
]
Zheng Hu commented on HBASE-18368:
--
[~allan163], if you do not have time, I can try to fix the bug ( by
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115650#comment-16115650
]
Ted Yu commented on HBASE-18368:
[~allan163]:
Do you have time to resume the work here ?
> FilterList
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098048#comment-16098048
]
Allan Yang commented on HBASE-18368:
{quote}
What do you think of above comments ?
{quote}
Yes, add a
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098004#comment-16098004
]
Guanghao Zhang commented on HBASE-18368:
bq. I think it should be called NEXT_FAMILY if we want
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097999#comment-16097999
]
Ted Yu commented on HBASE-18368:
[~allan163]:
What do you think of above comments ?
> FilterList with
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094094#comment-16094094
]
Duo Zhang commented on HBASE-18368:
---
{quote}
We should tell the filter developer that even you return a
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094088#comment-16094088
]
Zheng Hu commented on HBASE-18368:
--
bq. We should tell the filter developer that even you return a
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094081#comment-16094081
]
Guanghao Zhang commented on HBASE-18368:
I thought one easy fix is change the java doc of
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093666#comment-16093666
]
Sean Busbey commented on HBASE-18368:
-
bq. (assuming 1.4.0 release is around the corner).
1.4.0 has
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093066#comment-16093066
]
Ted Yu commented on HBASE-18368:
For RowCountFilter, the correct method to override is (assuming the
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092995#comment-16092995
]
Zheng Hu commented on HBASE-18368:
--
bq. I don't think the UT you provided is valid, as we change a
[
https://issues.apache.org/jira/browse/HBASE-18368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092810#comment-16092810
]
Allan Yang commented on HBASE-18368:
{quote}
The key thing is every column family's store scanner
39 matches
Mail list logo
