[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123559#comment-16123559 ] Xiang Li commented on HBASE-18555: -- I feel that Append and Delete could be updated to use

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123556#comment-16123556 ] Xiang Li commented on HBASE-18555: -- Upload patch 001 to address [~chia7712]'s comment (Thanks very much)

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123394#comment-16123394 ] Mike Drob commented on HBASE-18555: --- Ah, ok, I see now. With putIfAbsent the code would have an extra

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123212#comment-16123212 ] Xiang Li commented on HBASE-18555: -- Hi Mike, Regarding bq. Your modification to getCellList makes it

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122434#comment-16122434 ] Jerry He commented on HBASE-18555: -- The patch saves the unnecessary last 'put' when the family already

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121898#comment-16121898 ] Mike Drob commented on HBASE-18555: --- Your modification to getCellList makes it look almost identical to

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121889#comment-16121889 ] Xiang Li commented on HBASE-18555: -- Hi Mike Drob, bq. This seems like the perfect use case for

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121884#comment-16121884 ] Chia-Ping Tsai commented on HBASE-18555: There is same issue in Delete, Append, Increment, and

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121858#comment-16121858 ] Xiang Li commented on HBASE-18555: -- The code has been there since HBASE-1304. > Remove redundant

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121851#comment-16121851 ] Mike Drob commented on HBASE-18555: --- This seems like the perfect use case for {{putIfAbsent}} > Remove

[jira] [Commented] (HBASE-18555) Remove redundant familyMap.put() from Put#addColumn() and addImmutable()

[ https://issues.apache.org/jira/browse/HBASE-18555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121848#comment-16121848 ] Jerry He commented on HBASE-18555: -- Nice little improvement. LGTM. > Remove redundant familyMap.put()