[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084788#comment-17084788
]
Hudson commented on HBASE-18651:
Results for branch branch-1
[build #1283 on
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16176137#comment-16176137
]
Hudson commented on HBASE-18651:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3757 (See
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175822#comment-16175822
]
Reid Chan commented on HBASE-18651:
---
Thanks for those reviews and suggestions [~tedyu], [~mdrob]
> Let
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175812#comment-16175812
]
Mike Drob commented on HBASE-18651:
---
LGTM. Pushed to master and branch-2, thanks for the patches Reid,
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175001#comment-16175001
]
Reid Chan commented on HBASE-18651:
---
ping [~mdrob], would you mind taking a look.
> Let
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174998#comment-16174998
]
Ted Yu commented on HBASE-18651:
Planning to commit later today if there is no further review comment.
>
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174260#comment-16174260
]
Hadoop QA commented on HBASE-18651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173300#comment-16173300
]
Mike Drob commented on HBASE-18651:
---
Patch looks good, only a few nits.
{code:title=ChaosMonkeyRunner}
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173113#comment-16173113
]
Reid Chan commented on HBASE-18651:
---
ping [~mdrob], what do think about the latest patch, suggestions
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171060#comment-16171060
]
Ted Yu commented on HBASE-18651:
lgtm
[~mdrob]:
Can you take a look.
> Let ChaosMonkeyRunner expose the
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171056#comment-16171056
]
Reid Chan commented on HBASE-18651:
---
ping [~tedyu], what do think about the latest patch.
> Let
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169689#comment-16169689
]
Hadoop QA commented on HBASE-18651:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169540#comment-16169540
]
Ted Yu commented on HBASE-18651:
{code}
+ // loop here until got killed
+ Thread.sleep(1);
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169321#comment-16169321
]
Hadoop QA commented on HBASE-18651:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169303#comment-16169303
]
Reid Chan commented on HBASE-18651:
---
{{-1shadedjars}} my patch is not related?
let me upload one
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169277#comment-16169277
]
Chia-Ping Tsai commented on HBASE-18651:
{code}
+ @Override
+ public void close() throws
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169261#comment-16169261
]
Hadoop QA commented on HBASE-18651:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168079#comment-16168079
]
Reid Chan commented on HBASE-18651:
---
I can code another version to see if meets your needs.
> Let
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168027#comment-16168027
]
Reid Chan commented on HBASE-18651:
---
I have observed other classes in hbase-it, none of them has
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16168001#comment-16168001
]
Ted Yu commented on HBASE-18651:
For the integration test, can you take a look at:
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167982#comment-16167982
]
Ted Yu commented on HBASE-18651:
{code}
+public class Monkeys implements Closeable {
{code}
Add
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16167918#comment-16167918
]
Reid Chan commented on HBASE-18651:
---
any suggestions. [~tedyu] [~mdrob]
> Let ChaosMonkeyRunner expose
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166629#comment-16166629
]
Hadoop QA commented on HBASE-18651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166431#comment-16166431
]
Reid Chan commented on HBASE-18651:
---
QA may have problems again.
> Let ChaosMonkeyRunner expose the
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164782#comment-16164782
]
Ted Yu commented on HBASE-18651:
Reid:
Can you plug Monkeys class into code base to show its usage ?
>
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164757#comment-16164757
]
Mike Drob commented on HBASE-18651:
---
bq. +import com.google.common.base.Preconditions;
I think we have
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16164704#comment-16164704
]
Reid Chan commented on HBASE-18651:
---
ping [~mdrob], any suggestions to improve these codes.
> Let
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152662#comment-16152662
]
Ted Yu commented on HBASE-18651:
[~mdrob]:
What do you think ?
> Let ChaosMonkeyRunner expose the chaos
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152500#comment-16152500
]
Hadoop QA commented on HBASE-18651:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152447#comment-16152447
]
Reid Chan commented on HBASE-18651:
---
First version is based on my comprehension about the discussion in
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147526#comment-16147526
]
Ted Yu commented on HBASE-18651:
{code}
while (!stop) {// loop here until got killed
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145315#comment-16145315
]
Ted Yu commented on HBASE-18651:
Feel free to take this.
Thanks
> Let ChaosMonkeyRunner expose the
[
https://issues.apache.org/jira/browse/HBASE-18651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16145307#comment-16145307
]
Reid Chan commented on HBASE-18651:
---
hi, [~tedyu]
are you working on this jira? if not, may i?
> Let
33 matches
Mail list logo
