[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175536#comment-16175536
]
Zach York commented on HBASE-18773:
---
[~stack] I created HBASE-18860 to address where to move this file
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173965#comment-16173965
]
Hadoop QA commented on HBASE-18773:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173933#comment-16173933
]
Zach York commented on HBASE-18773:
---
[~stack] Yeah it didn't seem to belong in hbase-common, but I
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173903#comment-16173903
]
stack commented on HBASE-18773:
---
Ugh. My fault. Sorry for the neglect [~zyork].
Let me commit this though
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16170428#comment-16170428
]
Zach York commented on HBASE-18773:
---
[~stack] Sorry for the relentless pinging I know you are busy with
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166834#comment-16166834
]
Hadoop QA commented on HBASE-18773:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166771#comment-16166771
]
Zach York commented on HBASE-18773:
---
[~uagashe] I made the fix in the latest patch.
[~stack] What do
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166737#comment-16166737
]
Umesh Agashe commented on HBASE-18773:
--
+1 non-binding. One nit posted on reviewboard. Thanks for
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16166719#comment-16166719
]
Zach York commented on HBASE-18773:
---
[~stack] [~uagashe] [~tedyu] Ping?
I'm getting ready to put up
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165386#comment-16165386
]
Zach York commented on HBASE-18773:
---
[~stack] [~uagashe] [~tedyu] Any other concerns with the patch?
>
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163921#comment-16163921
]
Hadoop QA commented on HBASE-18773:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163901#comment-16163901
]
Hadoop QA commented on HBASE-18773:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163833#comment-16163833
]
Hadoop QA commented on HBASE-18773:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163816#comment-16163816
]
Zach York commented on HBASE-18773:
---
Added patch 004 to address issues [~tedyu] brought up in
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163776#comment-16163776
]
Zach York commented on HBASE-18773:
---
[~stack] I added a new patch that incorporates these comments.
>
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159645#comment-16159645
]
stack commented on HBASE-18773:
---
Sounds good.
Can you corral isMetaTableNameWithSuffix so it is
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16158989#comment-16158989
]
Zach York commented on HBASE-18773:
---
bq. Yeah. That looks about right. Make them the same.
[~stack] I
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157911#comment-16157911
]
stack commented on HBASE-18773:
---
bq. The only issue I see with this approach is that it might be confusing
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157904#comment-16157904
]
Zach York commented on HBASE-18773:
---
For some reason RB is not letting me publish my comment. Putting
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157784#comment-16157784
]
Hadoop QA commented on HBASE-18773:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157769#comment-16157769
]
Zach York commented on HBASE-18773:
---
[~uagashe] Ah, I originally did the dev on branch-1 where this
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157756#comment-16157756
]
Umesh Agashe commented on HBASE-18773:
--
[~zyork], there is existing method
{code}
public static
[
https://issues.apache.org/jira/browse/HBASE-18773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157722#comment-16157722
]
Zach York commented on HBASE-18773:
---
The reason this is broken out into a separate commit is because
23 matches
Mail list logo
