[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-06 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195336#comment-16195336 ] Appy commented on HBASE-18926: -- Oh! I meant "We can change api *till* beta1". bq. You meant we can NOT

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-06 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194821#comment-16194821 ] stack commented on HBASE-18926: --- bq. We can change api after beta1. So either way, should be okay to fix in

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-06 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194523#comment-16194523 ] Guanghao Zhang commented on HBASE-18926: Got it. Assigned HBASE-18950 (Remove Optional parameters

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16193023#comment-16193023 ] Duo Zhang commented on HBASE-18926: --- Seems OK. The only public or limited private API which uses

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-04 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192312#comment-16192312 ] Appy commented on HBASE-18926: -- We can change api *after* beta1. So either way, should be okay to fix in

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192309#comment-16192309 ] Duo Zhang commented on HBASE-18926: --- If there is no CP leak then beta1 is OK. Otherwise let’s make this

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-04 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192304#comment-16192304 ] Mike Drob commented on HBASE-18926: --- [~appy] [~Apache9] - can we put a fix version on this? Is it

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-02 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189256#comment-16189256 ] stack commented on HBASE-18926: --- Thanks for the pointer [~appy] The argument that Optional as param adds

[jira] [Commented] (HBASE-18926) Cleanup Optional from method params

2017-10-02 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-18926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189227#comment-16189227 ] Duo Zhang commented on HBASE-18926: --- Thanks [~appy]. > Cleanup Optional from method params >