[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214610#comment-16214610
]
stack commented on HBASE-19007:
---
Just noticed. No harm. You do loads of work around the place. I'll have
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214605#comment-16214605
]
Guanghao Zhang commented on HBASE-19007:
[~stack] the commit
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214132#comment-16214132
]
Hudson commented on HBASE-19007:
FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3927 (See
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16214129#comment-16214129
]
Hudson commented on HBASE-19007:
FAILURE: Integrated in Jenkins build HBase-2.0 #727 (See
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213849#comment-16213849
]
Hadoop QA commented on HBASE-19007:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213765#comment-16213765
]
stack commented on HBASE-19007:
---
.013 retry.
> Align Services Interfaces in Master and RegionServer
>
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213748#comment-16213748
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213626#comment-16213626
]
stack commented on HBASE-19007:
---
.012 fix a few tests (maybe not all -- let me see)
> Align Services
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213468#comment-16213468
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212945#comment-16212945
]
stack commented on HBASE-19007:
---
.011 fix test and findbugs.
> Align Services Interfaces in Master and
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212865#comment-16212865
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212205#comment-16212205
]
stack commented on HBASE-19007:
---
.009 findbugs and test failure fix.
> Align Services Interfaces in Master
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211937#comment-16211937
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211773#comment-16211773
]
Mike Drob commented on HBASE-19007:
---
Triggered retry on Jenkins.
> Align Services Interfaces in Master
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211688#comment-16211688
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211666#comment-16211666
]
stack commented on HBASE-19007:
---
.008 removed *services from Environment so you can't get at it even via
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211499#comment-16211499
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211485#comment-16211485
]
stack commented on HBASE-19007:
---
.007 addresses [~appy] and [~ram_krish] reviews on rb.
> Align Services
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210570#comment-16210570
]
ramkrishna.s.vasudevan commented on HBASE-19007:
If I get some time today will check this
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210255#comment-16210255
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210253#comment-16210253
]
stack commented on HBASE-19007:
---
Rebase.
> Align Services Interfaces in Master and RegionServer
>
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210221#comment-16210221
]
Hadoop QA commented on HBASE-19007:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16210195#comment-16210195
]
stack commented on HBASE-19007:
---
.005 is after a few rounds of great review by [~anoop.hbase]
Purge of
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208790#comment-16208790
]
stack commented on HBASE-19007:
---
.004 cleanup.Lets see how it does against hadoopqa. Below is commit
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208472#comment-16208472
]
Appy commented on HBASE-19007:
--
I think it's "reasonable" because although the method is ugly, we get two
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208463#comment-16208463
]
Appy commented on HBASE-19007:
--
sounds reasonable way to move forward for now.
> Align Services Interfaces
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208292#comment-16208292
]
stack commented on HBASE-19007:
---
.003 is the way to go I think.
It does this:
+ Adds an annotation
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16208179#comment-16208179
]
stack commented on HBASE-19007:
---
.002 adds marker interfaces that allows you get *Services. Dirty but
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207894#comment-16207894
]
stack commented on HBASE-19007:
---
[~zghaobac] Yes sir. Am on it.
[~ram_krish] and [~anoop.hbase] Thank you
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207785#comment-16207785
]
Guanghao Zhang commented on HBASE-19007:
Sorry to join this discussion late. IMO, use Server to
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207660#comment-16207660
]
Anoop Sam John commented on HBASE-19007:
bq.Agree. Do we have to add an CoprocessorAbortException
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207653#comment-16207653
]
Anoop Sam John commented on HBASE-19007:
Generally I like and agree to the idea of not expose the
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207221#comment-16207221
]
ramkrishna.s.vasudevan commented on HBASE-19007:
[~saint@gmail.com]
Spent some time
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207036#comment-16207036
]
stack commented on HBASE-19007:
---
[~appy] [~ram_krish] or [~anoop.hbase] Perhaps you have ideas.
> Align
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207018#comment-16207018
]
stack commented on HBASE-19007:
---
On @appy comments...
bq. Even if the original author designed these for
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207012#comment-16207012
]
stack commented on HBASE-19007:
---
.001 WIP Bit stuck because we've given access that should not be allowed
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206520#comment-16206520
]
Appy commented on HBASE-19007:
--
So seeing Server exposed, something irked, and these are my lines of
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205436#comment-16205436
]
ramkrishna.s.vasudevan commented on HBASE-19007:
Proposal makes sense.
> Align Services
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205160#comment-16205160
]
stack commented on HBASE-19007:
---
Makes sense. Yes.
> Align Services Interfaces in Master and RegionServer
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205059#comment-16205059
]
Anoop Sam John commented on HBASE-19007:
bq./ in RegionServerCoprocessorEnvironment and ditton in
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204766#comment-16204766
]
stack commented on HBASE-19007:
---
bq. Means the CP required things in RS side like getConnection() will be
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204522#comment-16204522
]
Anoop Sam John commented on HBASE-19007:
I like the way NOT to expose RSS or MS directly.
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204485#comment-16204485
]
stack commented on HBASE-19007:
---
[~appy] we > 1 + 1
> Align Services Interfaces in Master and RegionServer
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204387#comment-16204387
]
Appy commented on HBASE-19007:
--
Am very very happy with this design.
But am sad why didn't it strike me
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204381#comment-16204381
]
stack commented on HBASE-19007:
---
Chatted w/ [~appy]. We came up w/ this proposal:
* Undo exposing
[
https://issues.apache.org/jira/browse/HBASE-19007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204355#comment-16204355
]
stack commented on HBASE-19007:
---
One thought is to remove CoprocessorRegionServerServices and instead just
46 matches
Mail list logo
