[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816926#comment-16816926 ] Hudson commented on HBASE-19008: Results for branch branch-1.4 [build #745 on

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816899#comment-16816899 ] Hudson commented on HBASE-19008: Results for branch branch-1 [build #771 on

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815970#comment-16815970 ] Hudson commented on HBASE-19008: Results for branch branch-2.0 [build #1512 on

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815955#comment-16815955 ] Hudson commented on HBASE-19008: Results for branch branch-2.1 [build #1046 on

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591659#comment-16591659 ] Hudson commented on HBASE-19008: Results for branch master [build #452 on

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591041#comment-16591041 ] liubangchen commented on HBASE-19008: - I have in bed last night, Thank you very much [~reidchan]

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590959#comment-16590959 ] Hudson commented on HBASE-19008: Results for branch branch-2 [build #1153 on

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590498#comment-16590498 ] Reid Chan commented on HBASE-19008: --- Done, thanks Ted. > Add missing equals or hashCode method(s) to

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590475#comment-16590475 ] Ted Yu commented on HBASE-19008: Reid: You can drop the changes to 19008-21.patch in patch v21 and apply

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590466#comment-16590466 ] Reid Chan commented on HBASE-19008: --- It's better you can provide a patch for branch-2. [~liubangchen]

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590461#comment-16590461 ] Reid Chan commented on HBASE-19008: --- Pushed to master branch only, branch-2 doesn't have

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590414#comment-16590414 ] Ted Yu commented on HBASE-19008: TestFlushWithThroughputController is being handled in HBASE-21097 .

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589853#comment-16589853 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589645#comment-16589645 ] liubangchen commented on HBASE-19008: - I get it. Thank you very much [~reidchan]

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589639#comment-16589639 ] Reid Chan commented on HBASE-19008: --- bq. Does is correct to use git diff command to generate patch?

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589630#comment-16589630 ] Ted Yu commented on HBASE-19008: See:

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589619#comment-16589619 ] liubangchen commented on HBASE-19008: - Does is correct to use git diff command to generate patch?

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589613#comment-16589613 ] Reid Chan commented on HBASE-19008: --- Use git format-patch to generate patch will keep your credit

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589581#comment-16589581 ] liubangchen commented on HBASE-19008: - [~reidchan] [~yuzhih...@gmail.com] Thank you for you help. :)

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589400#comment-16589400 ] Ted Yu commented on HBASE-19008: Reid: Please go ahead with merge. > Add missing equals or hashCode

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588935#comment-16588935 ] Reid Chan commented on HBASE-19008: --- *{color:green}+1{color}* > Add missing equals or hashCode

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588891#comment-16588891 ] Ted Yu commented on HBASE-19008: Test failures were not related to the patch. > Add missing equals or

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1655#comment-1655 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588554#comment-16588554 ] Reid Chan commented on HBASE-19008: --- Please upload the latest reviewed patch here to trigger QA. Good

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588423#comment-16588423 ] Hadoop QA commented on HBASE-19008: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587905#comment-16587905 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587376#comment-16587376 ] Reid Chan commented on HBASE-19008: --- Leave some comments in review board, most of them are the same.

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587329#comment-16587329 ] Hadoop QA commented on HBASE-19008: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587123#comment-16587123 ] Reid Chan commented on HBASE-19008: --- Please upload the latest patch to review board. > Add missing

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587121#comment-16587121 ] Ted Yu commented on HBASE-19008: TestMergeTableRegionsProcedure is not related to Filter. > Add missing

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587118#comment-16587118 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586910#comment-16586910 ] liubangchen commented on HBASE-19008: - [~reidchan] Thank you for you help . I will fix it and submit

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586884#comment-16586884 ] Reid Chan commented on HBASE-19008: --- {{SingleColumnValueExcludeFilter}} extends

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586873#comment-16586873 ] Reid Chan commented on HBASE-19008: --- Tried to take a detailed look, feeling sorry there're bunch of

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586867#comment-16586867 ] Reid Chan commented on HBASE-19008: --- {code} import org.apache.hadoop.hbase.Cell; import

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586853#comment-16586853 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you help Liubang out ? > Add missing equals or

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584699#comment-16584699 ] liubangchen commented on HBASE-19008: - Hi, [~reidchan] cloud help me to to find format and

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584197#comment-16584197 ] Reid Chan commented on HBASE-19008: --- please fix the last two checkstyle problems and trigger QA again.

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584187#comment-16584187 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you take another look ? > Add missing equals or

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582932#comment-16582932 ] Ted Yu commented on HBASE-19008: Failure in TestZKSecretWatcher was not related to the patch. > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582899#comment-16582899 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582374#comment-16582374 ] Reid Chan commented on HBASE-19008: --- At least, we are near the end :) {{checkstyle}}:

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582360#comment-16582360 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you take another look ? > Add missing equals or

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581977#comment-16581977 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581561#comment-16581561 ] Ted Yu commented on HBASE-19008: Please refer to

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581424#comment-16581424 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580243#comment-16580243 ] Ted Yu commented on HBASE-19008: Please address checkstyle warnings in hbase-spark module: {code}

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580026#comment-16580026 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579784#comment-16579784 ] liubangchen commented on HBASE-19008: - Use dev-support/hbase_eclipse_formatter.xml as format profile

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579259#comment-16579259 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579193#comment-16579193 ] Reid Chan commented on HBASE-19008: --- Still lots of problems. :). {quote}we have a formatter template

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579191#comment-16579191 ] Ted Yu commented on HBASE-19008: [~liuml07]: Can you see if your comments have been addressed ? > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16579178#comment-16579178 ] Ted Yu commented on HBASE-19008: [~reidchan]: Can you see if your comments have been addressed ? > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578912#comment-16578912 ] Ted Yu commented on HBASE-19008: Please fix 8 checkstyle warnings in hbase-server module, 3 in

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578798#comment-16578798 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578494#comment-16578494 ] liubangchen commented on HBASE-19008: - I use Emacs and google-code-style. Now I use IDEA to format

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572602#comment-16572602 ] Reid Chan commented on HBASE-19008: --- For {{checkstyle}} problem, can you please pay attention to

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572092#comment-16572092 ] Ted Yu commented on HBASE-19008: [~reidchan] [~Jan Hentschel]: Can you take a look ? > Add missing

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571861#comment-16571861 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571482#comment-16571482 ] liubangchen commented on HBASE-19008: - Fix issues for checkstyle. > Add missing equals or hashCode

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571446#comment-16571446 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570507#comment-16570507 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570216#comment-16570216 ] liubangchen commented on HBASE-19008: - Fix issues for FindBugs and CheckStyle. > Add missing equals

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570106#comment-16570106 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570012#comment-16570012 ] Ted Yu commented on HBASE-19008: Please fix the following compilation errors: {code} [ERROR]

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569771#comment-16569771 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569678#comment-16569678 ] liubangchen commented on HBASE-19008: - Fix issues for Hadoop QA. > Add missing equals or hashCode

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568394#comment-16568394 ] Ted Yu commented on HBASE-19008: {code} [ERROR]

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568151#comment-16568151 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568041#comment-16568041 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567943#comment-16567943 ] liubangchen commented on HBASE-19008: - [~liuml07] Thank you for you suggestion.I have resolved all

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567857#comment-16567857 ] Mingliang Liu commented on HBASE-19008: --- # The common code in {{equals}} can follow a simpler

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567793#comment-16567793 ] Hadoop QA commented on HBASE-19008: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567686#comment-16567686 ] liubangchen commented on HBASE-19008: - [~reidchan] Thank you for reminding. I have resolved all

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565344#comment-16565344 ] Reid Chan commented on HBASE-19008: --- Any criterion about which Filter should implement those methods?

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565163#comment-16565163 ] Ted Yu commented on HBASE-19008: Liubang: Can you add the two methods to RowFilter.java ? Thanks > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565142#comment-16565142 ] Ted Yu commented on HBASE-19008: Liubang: Can you attach the patch here for QA run ? thanks > Add

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564927#comment-16564927 ] liubangchen commented on HBASE-19008: - [~Jan Hentschel] Thanks . Add equals and hashCode for Filters

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559364#comment-16559364 ] Jan Hentschel commented on HBASE-19008: --- [~liubangchen] Sure, go ahead. > Add missing equals or

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559198#comment-16559198 ] liubangchen commented on HBASE-19008: - [~Jan Hentschel] If you have no time, I can take this

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558634#comment-16558634 ] Jan Hentschel commented on HBASE-19008: --- [~yuzhih...@gmail.com] Yes, we should definitely do this.

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558088#comment-16558088 ] liubangchen commented on HBASE-19008: - ping [~Jan Hentschel] , Could I can resolve this issure ？ >

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552969#comment-16552969 ] Ted Yu commented on HBASE-19008: In the thread, 'Adding same row filter multiple times', Biplob brought

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219180#comment-16219180 ] Ted Yu commented on HBASE-19008: Thanks for taking this, Jan. > Add missing equals or hashCode method(s)

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205996#comment-16205996 ] Ted Yu commented on HBASE-19008: In HBASE-15410, I used Set for Filters in early patches. Later on, I

[jira] [Commented] (HBASE-19008) Add missing equals or hashCode method(s) to stock Filter implementations

[ https://issues.apache.org/jira/browse/HBASE-19008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16205442#comment-16205442 ] ramkrishna.s.vasudevan commented on HBASE-19008: We need equals and hashcode for Filters?