[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-11-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16240551#comment-16240551 ] Ted Yu commented on HBASE-19052: [~mdrob]: See the description of this JIRA for your question over

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-28 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223699#comment-16223699 ] stack commented on HBASE-19052: --- bq. When we will able to change this and write the CellComparatorImpl name

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-28 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223376#comment-16223376 ] Anoop Sam John commented on HBASE-19052: This comparator name change is the only thing we did as

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223139#comment-16223139 ] Andrew Purtell commented on HBASE-19052: Yes. I don't understand how we can't be backwards

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222845#comment-16222845 ] stack commented on HBASE-19052: --- I love the rationale that has it that because there is no test in issue A,

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222732#comment-16222732 ] Sean Busbey commented on HBASE-19052: - Also I guess call out that folks should not try to rolling

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread Sean Busbey (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222716#comment-16222716 ] Sean Busbey commented on HBASE-19052: - can we please update the hfile format appendix in the ref

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222682#comment-16222682 ] Anoop Sam John commented on HBASE-19052: bq.What happens if trailer has

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222667#comment-16222667 ] Ted Yu commented on HBASE-19052: Looking at HBASE-16189, there was no test. I am open to suggestion on

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222642#comment-16222642 ] stack commented on HBASE-19052: --- Why does this not have a test? We used to look for this } else if

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-27 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222637#comment-16222637 ] stack commented on HBASE-19052: --- Can't we do better than have hbase1 know about hbase2 classes and

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215554#comment-16215554 ] Hudson commented on HBASE-19052: FAILURE: Integrated in Jenkins build HBase-1.4 #966 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215512#comment-16215512 ] Hudson commented on HBASE-19052: FAILURE: Integrated in Jenkins build HBase-1.5 #109 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215471#comment-16215471 ] Hudson commented on HBASE-19052: SUCCESS: Integrated in Jenkins build HBase-1.1-JDK7 #1929 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215463#comment-16215463 ] Hudson commented on HBASE-19052: SUCCESS: Integrated in Jenkins build HBase-1.1-JDK8 #2013 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215430#comment-16215430 ] Ted Yu commented on HBASE-19052: Thanks for the reviews, Anoop and Ram. > FixedFileTrailer should

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215353#comment-16215353 ] Hudson commented on HBASE-19052: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #250 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215324#comment-16215324 ] Hudson commented on HBASE-19052: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #985 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215315#comment-16215315 ] Hudson commented on HBASE-19052: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #251 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215289#comment-16215289 ] Hudson commented on HBASE-19052: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #250 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215287#comment-16215287 ] Hudson commented on HBASE-19052: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #335 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215288#comment-16215288 ] Hudson commented on HBASE-19052: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #319 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215285#comment-16215285 ] Hudson commented on HBASE-19052: FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #247 (See

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-21 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213954#comment-16213954 ] Ted Yu commented on HBASE-19052: https://builds.apache.org/job/PreCommit-HBASE-Build/9299/console timed

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213688#comment-16213688 ] Ted Yu commented on HBASE-19052: https://builds.apache.org/job/PreCommit-HBASE-Build/9277/console :

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212946#comment-16212946 ] Anoop Sam John commented on HBASE-19052: +1 > FixedFileTrailer should recognize

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212749#comment-16212749 ] Ted Yu commented on HBASE-19052: New patch addresses Anoop's comment. > FixedFileTrailer should

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212474#comment-16212474 ] Hadoop QA commented on HBASE-19052: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread Anoop Sam John (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212454#comment-16212454 ] Anoop Sam John commented on HBASE-19052: 2.0 based HFiles handling is already there in

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-20 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16212290#comment-16212290 ] ramkrishna.s.vasudevan commented on HBASE-19052: I think you need to add a big fat

[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

2017-10-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211813#comment-16211813 ] Hadoop QA commented on HBASE-19052: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem