[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236119#comment-16236119 ] Hudson commented on HBASE-19118: SUCCESS: Integrated in Jenkins build HBase-1.2-IT #1000 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236118#comment-16236118 ] Hudson commented on HBASE-19118: FAILURE: Integrated in Jenkins build HBase-1.3-JDK7 #329 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236114#comment-16236114 ] Hudson commented on HBASE-19118: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #266 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236085#comment-16236085 ] Hudson commented on HBASE-19118: FAILURE: Integrated in Jenkins build HBase-1.3-JDK8 #346 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236078#comment-16236078 ] Hudson commented on HBASE-19118: FAILURE: Integrated in Jenkins build HBase-1.2-JDK7 #262 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236077#comment-16236077 ] Hudson commented on HBASE-19118: FAILURE: Integrated in Jenkins build HBase-1.2-JDK8 #258 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236044#comment-16236044 ] Hadoop QA commented on HBASE-19118: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235984#comment-16235984 ] Reid Chan commented on HBASE-19118: --- It's fine XD, thanks for your reviews [~elserj]! ping me if it

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235976#comment-16235976 ] Josh Elser commented on HBASE-19118: bq. qop accepts two kinds of stringQop as well. I'm not sure if

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235973#comment-16235973 ] Reid Chan commented on HBASE-19118: --- In branch-1.3 and branch-1.2 {code} QualityOfProtection qop =

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235901#comment-16235901 ] Reid Chan commented on HBASE-19118: --- bq. but I think your branch-1.3 breaks backwards compatibility.

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235891#comment-16235891 ] Josh Elser commented on HBASE-19118: bq. There're few different places in SaslUtil class, so i change

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235412#comment-16235412 ] Hudson commented on HBASE-19118: SUCCESS: Integrated in Jenkins build HBase-2.0 #784 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235355#comment-16235355 ] Hudson commented on HBASE-19118: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3984 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235307#comment-16235307 ] Hudson commented on HBASE-19118: FAILURE: Integrated in Jenkins build HBase-1.5 #129 (See

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235290#comment-16235290 ] Reid Chan commented on HBASE-19118: --- bq. my hunch is that one patch will do it Yes, i think so. > Use

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-02 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235271#comment-16235271 ] Reid Chan commented on HBASE-19118: --- Btw, remove some unused packages > Use SaslUtil to set Sasl.QOP

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-01 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235172#comment-16235172 ] Josh Elser commented on HBASE-19118: [~reidchan], can you take a look at branch-1.2 and branch-1.3

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-11-01 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235147#comment-16235147 ] Josh Elser commented on HBASE-19118: Nope, fine by me. Running through cherry-picking this to all the

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-31 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16232725#comment-16232725 ] Reid Chan commented on HBASE-19118: --- any suggestions? [~elserj] > Use SaslUtil to set Sasl.QOP in

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226251#comment-16226251 ] Ted Yu commented on HBASE-19118: lgtm > Use SaslUtil to set Sasl.QOP in 'Thrift' >

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226228#comment-16226228 ] Reid Chan commented on HBASE-19118: --- Yes, successfully. > Use SaslUtil to set Sasl.QOP in 'Thrift' >

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226221#comment-16226221 ] Reid Chan commented on HBASE-19118: --- Without this patch, only one of these values:

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226211#comment-16226211 ] Josh Elser commented on HBASE-19118: Ahh, sorry about that. I see that on second glance. I was

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226206#comment-16226206 ] Reid Chan commented on HBASE-19118: --- Thanks for reply! [~elserj] In {{SaslUtil}} {code} public

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226200#comment-16226200 ] Josh Elser commented on HBASE-19118: [~reidchan], while I agree with your choice in making the Thrift

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16226121#comment-16226121 ] Reid Chan commented on HBASE-19118: --- ping [~tedyu] [~chia7712], would you have time to give a review?

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224655#comment-16224655 ] Reid Chan commented on HBASE-19118: --- Can anyone give a review? Thanks in advance. > Use SaslUtil to

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224648#comment-16224648 ] Hadoop QA commented on HBASE-19118: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224536#comment-16224536 ] Hadoop QA commented on HBASE-19118: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16224476#comment-16224476 ] Reid Chan commented on HBASE-19118: --- No unit tests. > Use SaslUtil to set Sasl.QOP in 'Thrift' >

[jira] [Commented] (HBASE-19118) Use SaslUtil to set Sasl.QOP in 'Thrift'

2017-10-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1622#comment-1622 ] Hadoop QA commented on HBASE-19118: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem