[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-06 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280114#comment-16280114 ] Hudson commented on HBASE-19410: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279765#comment-16279765 ] Duo Zhang commented on HBASE-19410: --- Yes. Will commit shortly. Thanks. > Move zookeepe

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279662#comment-16279662 ] stack commented on HBASE-19410: --- Open new issue to talk testing revamp or just to dump idea

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279563#comment-16279563 ] Duo Zhang commented on HBASE-19410: --- One more thing, MiniHBaseCluster is marked as IA.P

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279562#comment-16279562 ] Duo Zhang commented on HBASE-19410: --- For us it is testing code but for users it is a li

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279545#comment-16279545 ] Appy commented on HBASE-19410: -- If that's more popular choice, am fine with it. Personally i

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279532#comment-16279532 ] Duo Zhang commented on HBASE-19410: --- I think for most users they just want to start a m

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279524#comment-16279524 ] Appy commented on HBASE-19410: -- What about this suggestion? bq. Maybe we can add another lin

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279499#comment-16279499 ] Duo Zhang commented on HBASE-19410: --- Oh just comment on RB, let me also put the comment

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279492#comment-16279492 ] stack commented on HBASE-19410: --- Refactor of test util is about due. HBTU was v2 as [~Apach

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279484#comment-16279484 ] Appy commented on HBASE-19410: -- (probably better place for discussion because of wider visib

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279301#comment-16279301 ] Duo Zhang commented on HBASE-19410: --- [~appy] Replied on RB, changing inheritence to com

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Appy (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279116#comment-16279116 ] Appy commented on HBASE-19410: -- Great refactor!! Few comments up on RB. > Move zookeeper re

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278942#comment-16278942 ] stack commented on HBASE-19410: --- [~Apache9] Our [~mdrob] is otherwise occupied next few day

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278350#comment-16278350 ] Duo Zhang commented on HBASE-19410: --- Any concerns? Thanks. > Move zookeeper related UT

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278218#comment-16278218 ] Hadoop QA commented on HBASE-19410: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277977#comment-16277977 ] Duo Zhang commented on HBASE-19410: --- Ping [~mdrob], our zk expert. And also [~appy], th

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-04 Thread Peter Somogyi (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276717#comment-16276717 ] Peter Somogyi commented on HBASE-19410: --- I like the change [~Apache9]! I put some c

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276276#comment-16276276 ] Chia-Ping Tsai commented on HBASE-19410: bq. ZKTests should be used for tests whi

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276275#comment-16276275 ] Duo Zhang commented on HBASE-19410: --- IMO, ZKTests should be used for tests which test t

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276269#comment-16276269 ] Duo Zhang commented on HBASE-19410: --- Let me check these tests. > Move zookeeper relate

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Chia-Ping Tsai (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276226#comment-16276226 ] Chia-Ping Tsai commented on HBASE-19410: beautiful refactor! What kind of test s

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276015#comment-16276015 ] Hadoop QA commented on HBASE-19410: --- | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275914#comment-16275914 ] Duo Zhang commented on HBASE-19410: --- Only checkstyle issues. Great. Let me fix them and

[jira] [Commented] (HBASE-19410) Move zookeeper related UTs to hbase-zookeeper and mark them as ZKTests

2017-12-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275884#comment-16275884 ] Hadoop QA commented on HBASE-19410: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo