[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310611#comment-16310611 ] Appy commented on HBASE-19613: -- I thought the changed removed stack trace all together. Didn't notice that

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309123#comment-16309123 ] BELUGA BEHR commented on HBASE-19613: - [~mdrob] As you said, you can add it back in if you would

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309105#comment-16309105 ] Hadoop QA commented on HBASE-19613: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309044#comment-16309044 ] Mike Drob commented on HBASE-19613: --- it currently prints the message at warn and the full stack trace

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309018#comment-16309018 ] BELUGA BEHR commented on HBASE-19613: - [~appy] I purposefully removed it because it's immediately

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309015#comment-16309015 ] Appy commented on HBASE-19613: -- Why removing {{ LOG.debug("exception details", exception);}}? If it was a

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308842#comment-16308842 ] Appy commented on HBASE-19613: -- It's not applying on master, can you please rebase it [~belugabehr]. Thanks.

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308831#comment-16308831 ] Appy commented on HBASE-19613: -- lgtm +1 Conversion of entryBuffer from LinkedList to ArrayList looks good

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

[ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16302961#comment-16302961 ] Hadoop QA commented on HBASE-19613: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem