[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416679#comment-16416679
]
Hudson commented on HBASE-20090:
Results for branch HBASE-19064
[build #77 on
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408915#comment-16408915
]
Hudson commented on HBASE-20090:
Results for branch branch-2
[build #513 on
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408727#comment-16408727
]
Hudson commented on HBASE-20090:
Results for branch branch-2.0
[build #69 on
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408156#comment-16408156
]
stack commented on HBASE-20090:
---
Pushed to branch-2 and branch-2.0.
> Properly handle Preconditions check
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407836#comment-16407836
]
Hudson commented on HBASE-20090:
Results for branch master
[build #268 on
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407427#comment-16407427
]
Ted Yu commented on HBASE-20090:
Integrated to master branch.
> Properly handle Preconditions check
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407425#comment-16407425
]
stack commented on HBASE-20090:
---
Now I get it. Thanks. Let me backport...
> Properly handle Preconditions
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407254#comment-16407254
]
Ted Yu commented on HBASE-20090:
bq. but we are still above the high-water mark?
At the moment of
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407204#comment-16407204
]
stack commented on HBASE-20090:
---
Yeah, sorry, RN makes no sense to me still but the description update
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407182#comment-16407182
]
Ted Yu commented on HBASE-20090:
I have updated both description and Release Note.
Thanks
> Properly
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16407149#comment-16407149
]
stack commented on HBASE-20090:
---
So, to understand the release note I have to read the description ...
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405145#comment-16405145
]
Ted Yu commented on HBASE-20090:
bq. Why would a region not receive writes?
Please see description
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405136#comment-16405136
]
stack commented on HBASE-20090:
---
How does this happen "... if the only candidate left doesn't receive
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405066#comment-16405066
]
stack commented on HBASE-20090:
---
Can we get a summary of what the problem is in release note and
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404392#comment-16404392
]
ramkrishna.s.vasudevan commented on HBASE-20090:
+1
> Properly handle Preconditions
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404377#comment-16404377
]
Anoop Sam John commented on HBASE-20090:
+1
> Properly handle Preconditions check failure in
>
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404237#comment-16404237
]
Ted Yu commented on HBASE-20090:
[~ram_krish] [~anoop.hbase]:
Mind taking a look at patch v10 ?
Thanks
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16403908#comment-16403908
]
Eshcar Hillel commented on HBASE-20090:
---
+1
> Properly handle Preconditions check failure in
>
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400881#comment-16400881
]
Ted Yu commented on HBASE-20090:
hadoopcheck seems to be related to build environment:
{code}
[ERROR]
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400872#comment-16400872
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400449#comment-16400449
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400200#comment-16400200
]
Ted Yu commented on HBASE-20090:
bq. was to replace the precondition check with a test that checks the
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400190#comment-16400190
]
Eshcar Hillel commented on HBASE-20090:
---
Still I am not convinced the code in the last patch covers
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399605#comment-16399605
]
Ted Yu commented on HBASE-20090:
[~stack]:
Do you want this to go into branch-2.0 ?
> Properly handle
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399149#comment-16399149
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398881#comment-16398881
]
ramkrishna.s.vasudevan commented on HBASE-20090:
+1. Thanks [~yuzhih...@gmail.com] for
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398720#comment-16398720
]
Ted Yu commented on HBASE-20090:
Logged HBASE-20196 for improving region size accounting.
Thanks
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398711#comment-16398711
]
Ted Yu commented on HBASE-20090:
Patch v9 adds comment explaining the race condition.
> Properly handle
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398672#comment-16398672
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398504#comment-16398504
]
Eshcar Hillel commented on HBASE-20090:
---
Yes, actually it makes sense to have all candidates sorted
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398497#comment-16398497
]
Ted Yu commented on HBASE-20090:
[~eshcar]:
I had another suggestion earlier:
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398353#comment-16398353
]
Anoop Sam John commented on HBASE-20090:
I think v8 looks very simple and most suitable. You
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398347#comment-16398347
]
Ted Yu commented on HBASE-20090:
See if patch v8 is better - it aligns with Eshcar's initial suggestion
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398277#comment-16398277
]
Eshcar Hillel commented on HBASE-20090:
---
I am still not convinced it is necessary. You are not
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397096#comment-16397096
]
Ted Yu commented on HBASE-20090:
bq. What can go wrong if you do not add A into the Set
{code}
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397086#comment-16397086
]
Eshcar Hillel commented on HBASE-20090:
---
yes to this set
> Properly handle Preconditions check
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397080#comment-16397080
]
Ted Yu commented on HBASE-20090:
bq. do not add A into the list
Can you be specific about which list ?
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397075#comment-16397075
]
Eshcar Hillel commented on HBASE-20090:
---
What can go wrong if you do not add A into the list (just
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397063#comment-16397063
]
Ted Yu commented on HBASE-20090:
{{getBiggestMemStoreRegion}} is called twice with different values for
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397017#comment-16397017
]
Eshcar Hillel commented on HBASE-20090:
---
So the suggested solution in v7 is to add region A into
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396552#comment-16396552
]
ramkrishna.s.vasudevan commented on HBASE-20090:
I like Ted's patch may be in case where
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396158#comment-16396158
]
Ted Yu commented on HBASE-20090:
Eshcar:
bq. calling to flushOneForGlobalPressure region A is not
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395817#comment-16395817
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395229#comment-16395229
]
Eshcar Hillel commented on HBASE-20090:
---
I am trying to see if I understand correctly the discussed
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389057#comment-16389057
]
Ted Yu commented on HBASE-20090:
I also thought about adding test.
Since the race condition revolves
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389046#comment-16389046
]
Ted Yu commented on HBASE-20090:
w.r.t. getBiggestMemstoreRegion(), there is 3rd parameter:
{code}
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388601#comment-16388601
]
stack commented on HBASE-20090:
---
Thanks.
While the Enis commit is from 3 years ago, in case you did not
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388591#comment-16388591
]
Ted Yu commented on HBASE-20090:
I have given example of exception from region server log above. Here is
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388586#comment-16388586
]
stack commented on HBASE-20090:
---
bq. Who wrote this code? Flag them. I'm sure they'd be interested. Do you
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388569#comment-16388569
]
Ted Yu commented on HBASE-20090:
Looking at the javadoc for getCopyOfOnlineRegionsSortedByOffHeapSize() :
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387971#comment-16387971
]
Ted Yu commented on HBASE-20090:
My understanding is that flushOneForGlobalPressure() has better view of
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387349#comment-16387349
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387313#comment-16387313
]
ramkrishna.s.vasudevan commented on HBASE-20090:
I think the case here is valid. As
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385924#comment-16385924
]
Ted Yu commented on HBASE-20090:
Here was how I produced the server log with additional DEBUG
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385919#comment-16385919
]
Ted Yu commented on HBASE-20090:
In another version of the patch I composed, fqe is passed to
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385904#comment-16385904
]
Ted Yu commented on HBASE-20090:
Relevant region server log snippet attached.
See if the snippet provided
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385709#comment-16385709
]
Anoop Sam John commented on HBASE-20090:
I did read the desc alone not the whole comments Ted.
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385681#comment-16385681
]
Ted Yu commented on HBASE-20090:
bq. Is this reproducible?
Though not 100% reproducible, this has high
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385676#comment-16385676
]
Ted Yu commented on HBASE-20090:
Thanks for taking a look, Anoop.
Did you read my explanation above the
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385659#comment-16385659
]
Anoop Sam John commented on HBASE-20090:
The thing to be checked is why a best region been
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385519#comment-16385519
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385441#comment-16385441
]
Ted Yu commented on HBASE-20090:
Patch v5 addresses checkstyle warning.
> Properly handle Preconditions
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385434#comment-16385434
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384221#comment-16384221
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383979#comment-16383979
]
Hadoop QA commented on HBASE-20090:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383887#comment-16383887
]
Ted Yu commented on HBASE-20090:
With more debug logging, we can see the scenario where the exception was
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383743#comment-16383743
]
Ted Yu commented on HBASE-20090:
Did some more testing on a 5 region server cluster with additional
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383215#comment-16383215
]
stack commented on HBASE-20090:
---
Why you posting a patch when you've not said what the problem
is nor how
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383213#comment-16383213
]
stack commented on HBASE-20090:
---
Patch is for the wrong issue?
> Properly handle Preconditions check
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383145#comment-16383145
]
Ted Yu commented on HBASE-20090:
It seems the Preconditions check can be converted to a normal condition
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377843#comment-16377843
]
Ted Yu commented on HBASE-20090:
Observed the following in region server log (in hadoop3 cluster):
{code}
[
https://issues.apache.org/jira/browse/HBASE-20090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377838#comment-16377838
]
stack commented on HBASE-20090:
---
Who wrote this code? Flag them. I'm sure they'd be interested. Do you have
72 matches
Mail list logo
