[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435616#comment-16435616
]
Hudson commented on HBASE-20243:
Results for branch master
[build #295 on
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435266#comment-16435266
]
Hudson commented on HBASE-20243:
Results for branch branch-2
[build #602 on
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434944#comment-16434944
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434854#comment-16434854
]
Guangxu Cheng commented on HBASE-20243:
---
Thanks all for reviewing.
> [Shell] Add shell command to
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434847#comment-16434847
]
Guangxu Cheng commented on HBASE-20243:
---
Attach new rebased patch 011.Thanks:)
> [Shell] Add shell
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434687#comment-16434687
]
Ted Yu commented on HBASE-20243:
Guangxu:
Mind a rebase ?
{code}
error: patch failed:
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434677#comment-16434677
]
Appy commented on HBASE-20243:
--
Beautiful. +100
> [Shell] Add shell command to create a new table by
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434048#comment-16434048
]
Ted Yu commented on HBASE-20243:
+1
> [Shell] Add shell command to create a new table by cloning the
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16434043#comment-16434043
]
Sean Busbey commented on HBASE-20243:
-
+1 thanks for the prompt update!
> [Shell] Add shell command
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433528#comment-16433528
]
Guangxu Cheng commented on HBASE-20243:
---
Patch 010 looks good now.
[~appy] [~busbey] Any other
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433514#comment-16433514
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432903#comment-16432903
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432590#comment-16432590
]
Guangxu Cheng commented on HBASE-20243:
---
Address rubocop warnings as [~busbey] suggestions. Retry
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432470#comment-16432470
]
Guangxu Cheng commented on HBASE-20243:
---
Thanks [~busbey] for review.I will address rubocop
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432359#comment-16432359
]
Sean Busbey commented on HBASE-20243:
-
please address rubocop warnings, by disabling the specific
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431797#comment-16431797
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431629#comment-16431629
]
Guangxu Cheng commented on HBASE-20243:
---
rubocop warnings are unrelated.
ruby-lint does not seem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430157#comment-16430157
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429693#comment-16429693
]
Guangxu Cheng commented on HBASE-20243:
---
Thanks [~appy] for pertinent suggests.
Some rubocop and
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426172#comment-16426172
]
Appy commented on HBASE-20243:
--
QA still not happy.
Would have been fine committing it if qa was green,
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426011#comment-16426011
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425791#comment-16425791
]
Guangxu Cheng commented on HBASE-20243:
---
Attach 007 patch to fix checkstyle warnings and some
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425255#comment-16425255
]
Ted Yu commented on HBASE-20243:
Guangxu:
Can you address the checkstyle warnings ?
Also, take a look at
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425155#comment-16425155
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425010#comment-16425010
]
Guangxu Cheng commented on HBASE-20243:
---
Attach 006 patch as [~appy] suggestions.Thanks
> [Shell]
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424850#comment-16424850
]
Guangxu Cheng commented on HBASE-20243:
---
{quote} - don't we need shell test too?
- use a variable
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424832#comment-16424832
]
Appy commented on HBASE-20243:
--
Patch looks good, few comments.
* don't we need shell test too?
* use a
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416987#comment-16416987
]
Guangxu Cheng commented on HBASE-20243:
---
Merge rebase due to latest changes. Updated the patch
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413774#comment-16413774
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413592#comment-16413592
]
Guangxu Cheng commented on HBASE-20243:
---
Attach 004 patch to fix failed tests.Thanks
> [Shell] Add
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413365#comment-16413365
]
Hadoop QA commented on HBASE-20243:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411105#comment-16411105
]
Appy commented on HBASE-20243:
--
bq. I think it would be more convenient if we had a command to clone the
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409241#comment-16409241
]
Guangxu Cheng commented on HBASE-20243:
---
[~ashish singhi] Of course，it is okay, but I think it
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409227#comment-16409227
]
Ashish Singhi commented on HBASE-20243:
---
Hi [~andrewcheng],
So only I mentioned just after creating
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409178#comment-16409178
]
Guangxu Cheng commented on HBASE-20243:
---
hi，[~ashish singhi]. In our scenario, we need to create a
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409154#comment-16409154
]
Ashish Singhi commented on HBASE-20243:
---
Why not after creating the table, take a snapshot and then
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409146#comment-16409146
]
Guangxu Cheng commented on HBASE-20243:
---
{quote}The new method is called cloneTable. But it only
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408062#comment-16408062
]
Ted Yu commented on HBASE-20243:
{code}
2726 * @param newTableName name of the new table where the
[
https://issues.apache.org/jira/browse/HBASE-20243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408034#comment-16408034
]
Guangxu Cheng commented on HBASE-20243:
---
Upload the first patch for review.Thanks
> [Shell] Add
39 matches
Mail list logo
