[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569515#comment-16569515
]
stack commented on HBASE-20846:
---
bq. Duo Zhang, is there any problem for this fix before it can be
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569422#comment-16569422
]
Hudson commented on HBASE-20846:
Results for branch branch-2.0
[build #634 on
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16561847#comment-16561847
]
Allan Yang commented on HBASE-20846:
{quote}
Seems the flaky tests report can reproduce the problem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558308#comment-16558308
]
Duo Zhang commented on HBASE-20846:
---
Seems the flaky tests report can reproduce the problem of getting
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556315#comment-16556315
]
Hudson commented on HBASE-20846:
Results for branch branch-2.1
[build #103 on
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555963#comment-16555963
]
Hudson commented on HBASE-20846:
Results for branch branch-2
[build #1025 on
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555616#comment-16555616
]
Hudson commented on HBASE-20846:
Results for branch master
[build #408 on
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553175#comment-16553175
]
stack commented on HBASE-20846:
---
Link to HBASE-20924... An issue to backport to branch-2.0.
> Restore
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552366#comment-16552366
]
Duo Zhang commented on HBASE-20846:
---
Let me commit to branch-2.1+.
[~stack] For 2.0 I think we could
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551736#comment-16551736
]
stack commented on HBASE-20846:
---
We thinking this goes into 2.1 and 2.0? Seems risky for 2.0.x, even
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551688#comment-16551688
]
Duo Zhang commented on HBASE-20846:
---
Ping [~stack] for reviewing. It is on the RB now.
> Restore
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550321#comment-16550321
]
Duo Zhang commented on HBASE-20846:
---
{quote}
Nice writeup. Include in lock section on top of the
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549669#comment-16549669
]
Hadoop QA commented on HBASE-20846:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549564#comment-16549564
]
stack commented on HBASE-20846:
---
Nice writeup. Include in lock section on top of the class?
> Restore
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549364#comment-16549364
]
Duo Zhang commented on HBASE-20846:
---
Review board link:
https://reviews.apache.org/r/67973/
>
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549287#comment-16549287
]
Hadoop QA commented on HBASE-20846:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549096#comment-16549096
]
Duo Zhang commented on HBASE-20846:
---
{quote}
Most of patch content is swapping Procedure for
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548792#comment-16548792
]
stack commented on HBASE-20846:
---
On the patch...
Non-change in AbstractProcedureScheduler.java ?
Most of
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548787#comment-16548787
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547284#comment-16547284
]
Duo Zhang commented on HBASE-20846:
---
Tried the failed UT several times locally, all passed. The error
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547213#comment-16547213
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547003#comment-16547003
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16546646#comment-16546646
]
Duo Zhang commented on HBASE-20846:
---
Just ignore TestProcedureReplayOrder. Now we will restore locks
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545969#comment-16545969
]
Duo Zhang commented on HBASE-20846:
---
Thanks [~stack]. I checked the code, for a procedure in
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545861#comment-16545861
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545309#comment-16545309
]
stack commented on HBASE-20846:
---
bq. Now the biggest problem is that, the original code does not allow
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545192#comment-16545192
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544914#comment-16544914
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544874#comment-16544874
]
Duo Zhang commented on HBASE-20846:
---
Still have plenty of problems. Now the biggest problem is that,
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544297#comment-16544297
]
Hadoop QA commented on HBASE-20846:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544228#comment-16544228
]
Duo Zhang commented on HBASE-20846:
---
A first try.
TestMasterFailoverWithProcedures can not pass, I
31 matches
Mail list logo
