[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554243#comment-16554243 ] Hudson commented on HBASE-20878: Results for branch master [build #407 on

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554108#comment-16554108 ] Hudson commented on HBASE-20878: Results for branch branch-2.1 [build #98 on

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554077#comment-16554077 ] Hudson commented on HBASE-20878: Results for branch branch-2.0 [build #586 on

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554047#comment-16554047 ] Hudson commented on HBASE-20878: Results for branch branch-2 [build #1020 on

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553411#comment-16553411 ] Hadoop QA commented on HBASE-20878: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-23 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553157#comment-16553157 ] stack commented on HBASE-20878: --- +1 on patch. I reattached to see if the failure a fluke or related while

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553115#comment-16553115 ] Hadoop QA commented on HBASE-20878: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-23 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552421#comment-16552421 ] Allan Yang commented on HBASE-20878: uploaded a v4 patch, reuse some method from HBASE-20893, also

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-17 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547381#comment-16547381 ] stack commented on HBASE-20878: --- Patch LGTM. Good one. Nice comments in code on why this obtuse check.

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545260#comment-16545260 ] Hadoop QA commented on HBASE-20878: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542492#comment-16542492 ] Hadoop QA commented on HBASE-20878: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542444#comment-16542444 ] Allan Yang commented on HBASE-20878: I got your point, will change the patch. > Data loss if

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542403#comment-16542403 ] Duo Zhang commented on HBASE-20878: --- {quote} What if we bring back DLR(distributed log replay) back

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542395#comment-16542395 ] Allan Yang commented on HBASE-20878: uploaded a new patch, deleted the testing code. I think

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542361#comment-16542361 ] Duo Zhang commented on HBASE-20878: --- The patch contains some testing code? And I still think we should

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541880#comment-16541880 ] Hadoop QA commented on HBASE-20878: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541804#comment-16541804 ] Allan Yang commented on HBASE-20878: [~Apache9], you can see my patch, my solution is to check

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541630#comment-16541630 ] Duo Zhang commented on HBASE-20878: --- Yes I think this is a problem. We could add a check in MTRP, if

[jira] [Commented] (HBASE-20878) Data loss if merging regions while ServerCrashProcedure executing

2018-07-12 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541622#comment-16541622 ] stack commented on HBASE-20878: --- Makes sense. Good find. This has been a problem with all versions of