[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589971#comment-16589971
]
Hudson commented on HBASE-20943:
Results for branch master
[build #450 on
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589470#comment-16589470
]
huaxiang sun commented on HBASE-20943:
--
pushed to the master, let me put up a b1 patch.
> Add
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584476#comment-16584476
]
huaxiang sun commented on HBASE-20943:
--
I am going to commit it tonight, will put [~jinghanx]'s
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575836#comment-16575836
]
huaxiang sun commented on HBASE-20943:
--
hi [~jinghanx], I was about committing the change, and
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575304#comment-16575304
]
Hadoop QA commented on HBASE-20943:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575127#comment-16575127
]
Ted Yu commented on HBASE-20943:
lgtm
> Add offline/online region count into metrics
>
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575119#comment-16575119
]
huaxiang sun commented on HBASE-20943:
--
[~jinghanx], np, thanks for the contribution, I did some
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574996#comment-16574996
]
Ted Yu commented on HBASE-20943:
Looks good overall.
{code}
+ PairOfSameType getRegionNumbers();
{code}
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574992#comment-16574992
]
jinghan xu commented on HBASE-20943:
[~huaxiang] thx for taking care of it!
> Add offline/online
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574505#comment-16574505
]
Hadoop QA commented on HBASE-20943:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574316#comment-16574316
]
huaxiang sun commented on HBASE-20943:
--
v2 to clean up the checkstyle complains, unittest fails
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573853#comment-16573853
]
Hadoop QA commented on HBASE-20943:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573575#comment-16573575
]
huaxiang sun commented on HBASE-20943:
--
I tested locally, the unittest passed and the metrics shows
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573401#comment-16573401
]
jinghan xu commented on HBASE-20943:
updated the number to count.
> Add offline/online region count
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572672#comment-16572672
]
huaxiang sun commented on HBASE-20943:
--
[~jinghanx], I will update it when I commit. Let me kick
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572540#comment-16572540
]
Ted Yu commented on HBASE-20943:
{code}
60String ONLINE_REGION_NUMBER_NAME =
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572525#comment-16572525
]
jinghan xu commented on HBASE-20943:
thx [~huaxiang] , I updated it to return a pair
> Add
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572030#comment-16572030
]
Tianying Chang commented on HBASE-20943:
[~huaxiang] thanks for reviewing!
> Add
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570978#comment-16570978
]
huaxiang sun commented on HBASE-20943:
--
Hi [~jinghanx], the patch looks good. One nit, can
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570665#comment-16570665
]
Tianying Chang commented on HBASE-20943:
[~yuzhih...@gmail.com] it seems I cannot assign this
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570663#comment-16570663
]
jinghan xu commented on HBASE-20943:
hey [~yuzhih...@gmail.com], can you help adding me into the
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16570561#comment-16570561
]
Tianying Chang commented on HBASE-20943:
[~yuzhih...@gmail.com] Thanks. My teammate Jinghan Xu
[
https://issues.apache.org/jira/browse/HBASE-20943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16556437#comment-16556437
]
Ted Yu commented on HBASE-20943:
Looking forward to the patch.
> Add offline/online region count into
23 matches
Mail list logo
