[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589965#comment-16589965 ] Hudson commented on HBASE-21031: Results for branch master [build #450 on

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589814#comment-16589814 ] Hudson commented on HBASE-21031: Results for branch branch-2 [build #1148 on

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589621#comment-16589621 ] Hudson commented on HBASE-21031: Results for branch branch-2.1 [build #226 on

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589594#comment-16589594 ] Hudson commented on HBASE-21031: Results for branch branch-2.0 [build #715 on

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588076#comment-16588076 ] Hadoop QA commented on HBASE-21031: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-21 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587891#comment-16587891 ] stack commented on HBASE-21031: --- Retry while [~allan163] is offline. > Memory leak if replay edits failed

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-21 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587558#comment-16587558 ] Hadoop QA commented on HBASE-21031: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-21 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587483#comment-16587483 ] Mike Drob commented on HBASE-21031: --- +1 assuming QA agrees, thanks for working on this! > Memory leak

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-21 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587350#comment-16587350 ] Allan Yang commented on HBASE-21031: {quote} + LOG.error("replay failed, that's expected", t); I

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581501#comment-16581501 ] Mike Drob commented on HBASE-21031: --- {quote} + LOG.warn("Failed drop memstore of region= {},

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-15 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581499#comment-16581499 ] Mike Drob commented on HBASE-21031: --- bq. +LOG.error("replay failed, that's expected", t); I

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577798#comment-16577798 ] Allan Yang commented on HBASE-21031: Thanks for reviewing, [~yuzhih...@gmail.com]. Any other

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577686#comment-16577686 ] Hadoop QA commented on HBASE-21031: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577592#comment-16577592 ] Ted Yu commented on HBASE-21031: Looks good overall. > Memory leak if replay edits failed during

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577584#comment-16577584 ] Hadoop QA commented on HBASE-21031: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577496#comment-16577496 ] Allan Yang commented on HBASE-21031: {quote} Can you come up with a test which fails if

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577482#comment-16577482 ] Allan Yang commented on HBASE-21031: [~yuzhih...@gmail.com], just checked, master branch and

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576494#comment-16576494 ] Ted Yu commented on HBASE-21031: Can you come up with a test which fails if {{dropMemStoreContents}}

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576492#comment-16576492 ] Allan Yang commented on HBASE-21031: {quote} TestRecoveredEidtsReplayAndAbort passes with the above

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576466#comment-16576466 ] Ted Yu commented on HBASE-21031: I modified the dropMemStoreContents() method by passing it the region

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576432#comment-16576432 ] Hadoop QA commented on HBASE-21031: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576025#comment-16576025 ] Hadoop QA commented on HBASE-21031: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-10 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575858#comment-16575858 ] Allan Yang commented on HBASE-21031: [~mdrob], uploaded the new patch to the review board, feel free

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575027#comment-16575027 ] Hadoop QA commented on HBASE-21031: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21031) Memory leak if replay edits failed during region opening

2018-08-09 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574986#comment-16574986 ] Mike Drob commented on HBASE-21031: --- Very interesting failure scenario, Allan. Great job diagnosing