[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835132#comment-16835132
]
Zach York commented on HBASE-21070:
---
[~busbey] So this commit is just for adding the test, I would
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834878#comment-16834878
]
Sean Busbey commented on HBASE-21070:
-
a release note too please.
> SnapshotFileCache won't update
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834866#comment-16834866
]
Sean Busbey commented on HBASE-21070:
-
should go to maintenance branches too I think?
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834450#comment-16834450
]
Hudson commented on HBASE-21070:
Results for branch master
[build #987 on
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834438#comment-16834438
]
Hudson commented on HBASE-21070:
Results for branch branch-2
[build #1872 on
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834410#comment-16834410
]
Hudson commented on HBASE-21070:
Results for branch branch-1
[build #808 on
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834295#comment-16834295
]
Zach York commented on HBASE-21070:
---
Pushed to master, branch-1, and branch-2. Shout if it needs to go
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830835#comment-16830835
]
HBase QA commented on HBASE-21070:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830638#comment-16830638
]
Zach York commented on HBASE-21070:
---
Sorry [~apurtell]. I lost this issue for a bit while I had
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16815582#comment-16815582
]
Andrew Purtell commented on HBASE-21070:
Any progress here? Or unschedule it? Or close it?
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786407#comment-16786407
]
Hadoop QA commented on HBASE-21070:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754531#comment-16754531
]
Mingliang Liu commented on HBASE-21070:
---
# The UT is simple but makes sure we don't rely on the
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754493#comment-16754493
]
Zach York commented on HBASE-21070:
---
[~liuml07] Can you take a look when you get a chance?
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1671#comment-1671
]
Zach York commented on HBASE-21070:
---
I fixed the checkstyle issue locally.
> SnapshotFileCache won't
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744417#comment-16744417
]
Hadoop QA commented on HBASE-21070:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744323#comment-16744323
]
Mingliang Liu commented on HBASE-21070:
---
I myself has been working on something else in public
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16744240#comment-16744240
]
Zach York commented on HBASE-21070:
---
[~liuml07] Sorry for the long, long silence. I got busy with
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640478#comment-16640478
]
Zach York commented on HBASE-21070:
---
I was basically working on fixing the test as
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605070#comment-16605070
]
Zach York commented on HBASE-21070:
---
Sorry for being a little absent on this over the past couple
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598122#comment-16598122
]
Mingliang Liu commented on HBASE-21070:
---
Thanks [~zyork]. If all access methods are synchronized,
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595745#comment-16595745
]
Zach York commented on HBASE-21070:
---
Good catch on readLock, missed removing that.
The volatile
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594403#comment-16594403
]
Mingliang Liu commented on HBASE-21070:
---
Last, I think it might be helpful to add a UT. Thanks,
>
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594402#comment-16594402
]
Mingliang Liu commented on HBASE-21070:
---
The patch looks good to me overall to remove the
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594345#comment-16594345
]
Hadoop QA commented on HBASE-21070:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594275#comment-16594275
]
Zach York commented on HBASE-21070:
---
patch 2 adds additionally logging suggested by [~stack].
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586538#comment-16586538
]
Zach York commented on HBASE-21070:
---
All these tests pass locally.
> SnapshotFileCache won't update
[
https://issues.apache.org/jira/browse/HBASE-21070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584610#comment-16584610
]
Hadoop QA commented on HBASE-21070:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
27 matches
Mail list logo
