[ 
https://issues.apache.org/jira/browse/HBASE-21152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16815921#comment-16815921
 ] 

Biju Nair commented on HBASE-21152:
-----------------------------------

If {{status}} is used as a parameter for a shell command for e.g. {{describe 
status}} then {{status}} gets executed as a command followed by the user 
intended command i.e. {{describe}}. Looks like a broader issues and not 
confined to {{balance_switch}} command alone.

> Add parameter validations for commands in HBase shell
> -----------------------------------------------------
>
>                 Key: HBASE-21152
>                 URL: https://issues.apache.org/jira/browse/HBASE-21152
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer, shell
>            Reporter: Toshihiro Suzuki
>            Assignee: Toshihiro Suzuki
>            Priority: Major
>
> One of our customers got confused with "balance_switch" command in HBase 
> shell.
> They mistakenly ran "balance_swich status" command instead of 
> "balancer_enabled" command to see if the balancer is enabled. However, like 
> the following, it didn't cause any errors and it looks like the command was 
> successful. 
> {code}
> hbase> balance_switch status
> 1 active master, 0 backup masters, 1 servers, 0 dead, 2.0000 average load
> Took 0.0055 seconds
> Previous balancer state : true
> Took 0.0041 seconds
> => "true"
> {code}
> To make matters worse, the "balance_swich status" command will make the 
> balancer disabled.
> Of course, the command was wrong but I think that's a little bit confusing. 
> So I think we need to add parameter validations for commands in HBase shell. 
> I'll check if we need to add validations for any other commands in this Jira.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to